Optional<Stream>.filter(Optional::isPresent).map(Optional::get) to Java 11 .flatMap(Optional::stream)
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @timtebeek! What happens now? Will someone come and review? |
timtebeek
reviewed
Oct 18, 2023
src/main/java/org/openrewrite/java/migrate/util/OptionalStreamRecipe.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Impressed with the work you've done here! Really like the attention to detail in handling edge cases, and the suite of tests to show what's correctly handled. I've added some comments that I think would improve this PR still, and bring it closer to a merge.
Let me know if you'd be open to making those changes still!
src/main/java/org/openrewrite/java/migrate/util/OptionalStreamRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/util/OptionalStreamRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/util/OptionalStreamRecipe.java
Outdated
Show resolved
Hide resolved
src/main/java/org/openrewrite/java/migrate/util/OptionalStreamRecipe.java
Outdated
Show resolved
Hide resolved
timtebeek
changed the title
Optional<Stream>.filter(Optional::isPresent).map(Optional::get) to Java 11 .flatMap(Optional::stream)
timtebeek
reviewed
Oct 31, 2023
src/main/java/org/openrewrite/java/migrate/util/OptionalStreamRecipe.java
Outdated
Show resolved
Hide resolved
timtebeek
reviewed
Oct 31, 2023
src/test/java/org/openrewrite/java/migrate/util/OptionalStreamRecipeTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313
Problem
Java 8 Optional class didn't provide
::streammethod. As a result of this unfortunate mistake a popular idiom was created to flatten a Stream of Optionals:.filter(Optional::isPresent).map(Optional::get).This was corrected in Java 9 and the idiom may be replaced with
.flatMap(Optional::stream)Anything in particular you'd like reviewers to focus on?
This is my first adventure with OpenRewrite, please check everything carefully.
Checklist
./gradlew licenseFormat