CommonStaticAnalysis recipe does not change calls to getter/setters on camel casing changes.

[Murtuza24]

What version of OpenRewrite are you using?

I am using

rewrite-static-analysis_ v1.0.8

How are you running OpenRewrite?

I am using the Moderne CLI v 1.1.0.

mod build .
mod run . --recipe=CommonStaticAnalysis
mod apply . --last-recipe-run

What is the smallest, simplest way to reproduce the problem?

// lombok annotation
@Data
class A {
private String variable_name1;
private String variable_name2;
    // do something
}

class B {
  void setAData (){
     A a = new A();
     a.setvariable_name1("some value 1");
     a.setvariable_name2("some value 2");
   }
}

class C {
  void retreiveAData(A a) {
   String data1 = a.getvariable_name1();
   String data2 = a.getvariable_name2();
  }
}

What did you expect to see?

// lombok annotation
@Data
class A {
private String variableName1;
private String variableName2;
    // do something
}

class B {
  void setAData (){
     A a = new A();
     a.setVariableName1("some value 1");
     a.setVariableName2("some value 2");
   }
}

class C {
  void retreiveAData(A a) {
   String data1 = a.getVariableName1();
   String data2 = a.getVariableName2();
  }
}

What did you see instead?

// lombok annotation
@Data
class A {
private String variableName1;
private String variableName2;
    // do something
}

class B {
  void setAData (){
     A a = new A();
     a.setvariable_name1("some value 1");
     a.setvariable_name2("some value 2");
   }
}

class C {
  void retreiveAData(A a) {
   String data1 = a.getvariable_name1();
   String data2 = a.getvariable_name2();
  }
}

What is the full stack trace of any errors you encountered?

There are no errors while running the CommonStaticAnalysis v1.0.8 recipe.

Are you interested in contributing a fix to OpenRewrite?

[timtebeek]

Hi @Murtuza24 ; thanks for the detailed report, and using the Moderne CLI. Sorry to hear to output does not match what you had hoped for; that's down to OpenRewrite not yet supporting Lombok annotations. You can follow along to efforts there in this issue, but it's not an easy case to fix for us, due to the way Lombok is implemented

• Support Lombok Annotations rewrite#1297

What we can do however, and would fit in with our principle to "do no harm" is to make the recipe not rename any variables in the presence of lombok annotations. We already have such exceptions elsewhere I believe, and I imagine it would be fairly easy to add here as well.

Would you be open to start a draft pull request for this that adds tests that assert we don't make any changes when lombok annotations are present? That'd be the quickest way to get started on a fix. Such a test would be similar to this one here:

rewrite-static-analysis/src/test/java/org/openrewrite/staticanalysis/RenamePrivateFieldsToCamelCaseTest.java

Lines 481 to 496 in 012666b

	@Test
	void doNotRenameUnderscoreNumber() {
	rewriteRun(
	//language=java
	java(
	"""
	class A {
	private boolean _20th;
	public boolean method() {
	return _20th;
	}
	}
	"""
	)
	);
	}