Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Static JS bundle support #126

Closed
1 task done
wincowgerDEV opened this issue Mar 7, 2023 · 2 comments
Closed
1 task done

[Feature]: Static JS bundle support #126

wincowgerDEV opened this issue Mar 7, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request reviewer comment feedback from manuscript reviewers, should be prioritized

Comments

@wincowgerDEV
Copy link
Collaborator

Guidelines

  • I agree to follow this project's Contributing Guidelines.

Description

I just meant that it would be good to have a documentation on how to generate a static javascript bundle and upload it to a self-hosted webspace (e.g. locally for people wanting to use this model in an intranet or so).
Specifically, this means having something like

cd frontend
yarn build
cp dist

in the documentation. Regarding the disabled backend I've seen that it is possible to just use the frontend without any issues while testing this.
For gh pages it would just mean that you have an automatic gh action to generate a webpage which would then compile the js and copy it. You can simply use this action here https://github.com/marketplace/actions/github-pages-action and add your yarn build step. I think it should just work. The benefit would mainly be for development purposes, so people cloning the repo could immediately rollout the changes through this action.

Problem

Slow to deploy from docker and may not be necessary for all use cases.

Proposed Solution

cd frontend
yarn build
cp dist

Alternatives Considered

Expect Docker Deployment.

@wincowgerDEV wincowgerDEV added the enhancement New feature or request label Mar 7, 2023
@epierotti3 epierotti3 moved this to Needs Review in TrashAI Apr 5, 2023
@epierotti3 epierotti3 added this to the Complete Manuscript milestone Apr 5, 2023
@epierotti3 epierotti3 added the documentation Improvements or additions to documentation label Apr 5, 2023
@epierotti3 epierotti3 moved this from Needs Review to To-Do in TrashAI Apr 6, 2023
@shollingsworth
Copy link
Collaborator

Minus the aws/github stuff can this be closed with #127 and #107 ?

@wincowgerDEV wincowgerDEV added the reviewer comment feedback from manuscript reviewers, should be prioritized label May 16, 2023
@wincowgerDEV
Copy link
Collaborator Author

I think we have made a lot of progress on this and will let the reviewers know we are where we would like to be for deployment ease.

@github-project-automation github-project-automation bot moved this from To-Do to Done in TrashAI May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request reviewer comment feedback from manuscript reviewers, should be prioritized
Projects
Status: Done
Development

No branches or pull requests

3 participants