generated from opensafely-core/repo-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Cross-field Validation out of Pipeline et al #31
Comments
Some of the pain here, specificially mutating the This might be useful to #42, but we need to do more investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After moving job-runner's
project.py
into this library we'll have all validation done by pydantic. This is mostly very good, but where it falls down is where we have to mutate various values when reading them. Two good examples of this are:This has mostly cropped up when trying to type check various validator functions on the pydantic models, particularly those with
pre=True
set which are dealing with the raw data.I think a better approach here is going to be:
ProjectValidationError
).The text was updated successfully, but these errors were encountered: