Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element Wizards in SLD diagram should have the SCL Coordinates attributes editable #413

Closed
Flurb opened this issue Dec 7, 2021 · 3 comments · Fixed by #455
Closed

Element Wizards in SLD diagram should have the SCL Coordinates attributes editable #413

Flurb opened this issue Dec 7, 2021 · 3 comments · Fixed by #455
Assignees

Comments

@Flurb
Copy link
Contributor

Flurb commented Dec 7, 2021

As a CoMPAS user
I want elements in the SLD diagram who are eligible to have SCL coordinates be able to edit these attributes
So I can easily edit these attributes in the SLD diagram

Background:
The x, y and dir attributes should be editable for elements that are eligible to have SCL coordinates (ConductingEquipments for example).

@Sander3003
Copy link
Member

Sander3003 commented Dec 8, 2021

The already existing wizard can have 3 more fields: x, y and dir.
image

Because the wizard is also used in the Substation tab, a so-called 'extension' can be made of this Edit Wizard.
So we have different ones in SLD tab and Substation tab.

@JakobVogelsang
Copy link
Collaborator

I would suggest creating a new one based on the existing one. I know this might sound picky, but the fact that x,y and dir are defined in the appendix disqualifies those elements to be part of the wizard library. But as we need those textfields in the single line diagram only, we can copy the existing wizard to the singlelinediagram folder and just extend it as we need.

@Flurb
Copy link
Contributor Author

Flurb commented Dec 9, 2021

I would suggest creating a new one based on the existing one. I know this might sound picky, but the fact that x,y and dir are defined in the appendix disqualifies those elements to be part of the wizard library. But as we need those textfields in the single line diagram only, we can copy the existing wizard to the singlelinediagram folder and just extend it as we need.

That was also our plan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants