Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce parse function which returns ParsedCommand #1697

Closed
JonasCir opened this issue Jan 9, 2021 · 0 comments · Fixed by #1698
Closed

Introduce parse function which returns ParsedCommand #1697

JonasCir opened this issue Jan 9, 2021 · 0 comments · Fixed by #1698
Assignees
@JonasCir
Labels
has pull request Add this label when an issue has a PR which will resolve it refactor Code changes that neither fix a defect nor add functionality

Comments

@JonasCir
Copy link
Member

JonasCir commented Jan 9, 2021 •
edited
Loading

This has two advantages:

  1. By renaming, the call site in InputController.js gets more readable (see the PR)
  2. This keeps the diff low as

in a following PR, I want to split ParsedCommand into two parts (one which holds the data used in the InputController and one Parser class which does the parsing/validating). By this, we will have a clear processing pipeline of reading from the CLI -> parsing -> Error or Command returned.

forget it
I just noticed I can do it in one PR by introducing a parse function which returns a parsedCommand
@JonasCir JonasCir self-assigned this Jan 9, 2021
@JonasCir JonasCir mentioned this issue Jan 9, 2021
Merged
@JonasCir JonasCir changed the title [refactor] Rename CommandParser to ParsedCommand [refactor] ntroduce parse function which returns ParsedCommand Jan 9, 2021
@JonasCir JonasCir changed the title [refactor] ntroduce parse function which returns ParsedCommand [refactor] Introduce parse function which returns ParsedCommand Jan 9, 2021
@erikquinn erikquinn added has pull request Add this label when an issue has a PR which will resolve it refactor Code changes that neither fix a defect nor add functionality labels Jan 10, 2021
@erikquinn erikquinn changed the title [refactor] Introduce parse function which returns ParsedCommand Introduce parse function which returns ParsedCommand Jan 10, 2021
@erikquinn erikquinn mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonasCir JonasCir

Labels
has pull request Add this label when an issue has a PR which will resolve it refactor Code changes that neither fix a defect nor add functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor/1697 introduce parse function which returns ParsedCommand openscope/openscope
2 participants
@erikquinn @JonasCir