Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers for requests #162

Closed
ghost opened this issue Oct 9, 2020 · 2 comments
Closed

Headers for requests #162

ghost opened this issue Oct 9, 2020 · 2 comments
Assignees
@eblondel
Labels
data testing enhancement
Milestone
0.6

Comments

@ghost
Copy link

ghost commented Oct 9, 2020

Would it be worthwhile adding a header argument to the readSDMX function?

I'm testing the Australian Bureau of Statistics' new API (Beta). For my application, I have to authenticate with an access key in the header of the request.

Using the accessKey argument in readSDMX where the key gets added to the url as a parameter doesn't work in this instance, though I'm not sure if this is by design or an issue with the API.
@eblondel eblondel self-assigned this Oct 9, 2020
@ghost
Copy link
Author

ghost commented Oct 12, 2020

Proposed list argument added in #163. Apologies in advance, I'm new to sdmx and R package development - happy to make changes.

@eblondel eblondel modified the milestones: 0.5, 0.6 Oct 12, 2020
@eblondel
Copy link
Member

Merged in #163

@ghost ghost closed this as completed Oct 19, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eblondel eblondel

Labels
data testing enhancement
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@eblondel