Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlays positions when rotate #729

Closed
e1ty opened this issue Sep 17, 2015 · 6 comments
Closed

Overlays positions when rotate #729

e1ty opened this issue Sep 17, 2015 · 6 comments
Labels

Comments

@e1ty
Copy link

e1ty commented Sep 17, 2015

When I call viewport.setRotation and image rotates, overlays positions aren't changing and if you start to drag image, their position changes incorrectly.

@iangilman iangilman added the bug label Sep 17, 2015
@iangilman
Copy link
Member

Good point! Looks like we're kind of making an attempt; the position changes, and panning even seems to work (when I tried it) but zooming is totally wrong, and the size of the overlay changes incorrectly. Should definitely be looked into.

@avandecreme
Copy link
Member

Fixed by #896

@MMtechnolab
Copy link

i am working with openseadragon and fabric js canvas when , zoom is working perfectly for fabricjscanvas but rotate doesnt please check belowe link .download and run the demo.html then click on draw then draw on canvas then click rotate

https://github.com/MMtechnolab/OpenseadragonfabricjsDemo

@MMtechnolab
Copy link

@iangilman i have tried it but not working

@iangilman
Copy link
Member

Hmm... it looks like Fabric itself doesn't really support rotation, according to altert/OpenseadragonFabricjsOverlay#9. Btw, have you tried the suggestions in that issue? At any rate, you might need to follow up on that plugin or Fabric itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants