Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enable and fix legacy maps tests #2057

Open
kavilla opened this issue Aug 2, 2022 · 0 comments
Open

[BUG] Enable and fix legacy maps tests #2057

kavilla opened this issue Aug 2, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers maps Issues or PRs related to the Maps Service test:unit

Comments

@kavilla
Copy link
Member

kavilla commented Aug 2, 2022

Describe the bug
Origin:
https://github.com/opensearch-project/OpenSearch-Dashboards/pull/233/files

This tests were removed because at the time we didn't have a dedicated maps service but now that we do we can mock up some example responses that the tests are expecting.

To Reproduce
Remove the legacy map from Jest ignore and run yarn test:jest src/plugins/maps_legacy and watch failures

Expected behavior
Tests to passing

Additional context
#2042 introduces new logic that we can add more tests for.

@kavilla kavilla added bug Something isn't working untriaged test:unit maps Issues or PRs related to the Maps Service good first issue Good for newcomers labels Aug 2, 2022
@kavilla kavilla removed the untriaged label Aug 9, 2022
@joshuarrrr joshuarrrr added v1.3.7 and removed v1.3.7 labels Dec 2, 2022
@aoguan1990 aoguan1990 removed their assignment Feb 6, 2023
@AbhishekReddy1127 AbhishekReddy1127 removed their assignment Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers maps Issues or PRs related to the Maps Service test:unit
Projects
None yet
Development

No branches or pull requests

4 participants