Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Plugin versioning convention #2751

Open
ananzh opened this issue Nov 3, 2022 · 2 comments
Open

[Discuss] Plugin versioning convention #2751

ananzh opened this issue Nov 3, 2022 · 2 comments

Comments

@ananzh
Copy link
Member

ananzh commented Nov 3, 2022

Description
This is a discussion issue for plugin versioning. Currently, it is not clear about how to define version in opensearch_dashboards.yml for plugins. A suggestion is made here in this comment:

"version": "1.0.0",
"opensearchDashboardsVersion": "opensearchDashboards",

From this comment:
Interesting, I have never seen version being used in this way. I actually don't have a lot of context here. I left this section untouched from the autogenerated template when i created the VisBuilder plugin [Ref]

That being said, this is more relevant as far as i can tell for external plugins since its used to generate manifest files and check for version compatibility. e.g. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/packages/osd-plugin-helpers/src/tasks/update_versions.ts#L19

I have a hunch that having this value has something to do with whether its an internal or external plugin since internal plugins do not need matching versions with dashboards versions. I'd keep it as is for now since it works for other plugins and create a followup task to research on the implications of this value.

@ananzh ananzh changed the title [Discuss] Plugin version convention [Discuss] Plugin versioning convention Nov 3, 2022
@seanneumann
Copy link
Contributor

Triage - Need to come up with guidance on this one. @kavilla

@kavilla
Copy link
Member

kavilla commented Nov 9, 2022

Hey @ananzh,

By default plugins get built with 1.0.0 this can change but I believe the legacy convention to keep core plugin versions 1.0.0 without worrying about changing it. However, opensearchDashboardsVersion being set to opensearchDashboards allows for the plugin to work with any version of OpenSearch Dashboards. External plugins can do this as well as you mention.

Not sure if this behavior should be explicitly documented because even though plugins can set this there is guarantee that this will work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants