Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clean] @internal annotations used in OSD repo #2752

Open
ananzh opened this issue Nov 3, 2022 · 1 comment
Open

[Clean] @internal annotations used in OSD repo #2752

ananzh opened this issue Nov 3, 2022 · 1 comment
Labels
needs research technical debt If not paid, jeapardizes long-term success and maintainability of the repository.

Comments

@ananzh
Copy link
Member

ananzh commented Nov 3, 2022

Describe the bug
From table vis, we have noticed that there are many @internal annotations. If we search /** @internal */, there are about 123 results in 57 files. As commented here:

Usually we want other plugins to be able to use these interfaces and classes.

Should we get more understanding about these @internal annotations and remove the un-necessary ones?
@ananzh ananzh added untriaged technical debt If not paid, jeapardizes long-term success and maintainability of the repository. labels Nov 3, 2022
@ananzh ananzh mentioned this issue Nov 3, 2022
Merged
8 tasks
@seanneumann
Copy link
Contributor

Triage - Needs research.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs research technical debt If not paid, jeapardizes long-term success and maintainability of the repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seanneumann @ananzh