Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow grouping context menus with only 2 children #3171

Closed
sikhote opened this issue Jan 2, 2023 · 4 comments · Fixed by #3924
Closed

Allow grouping context menus with only 2 children #3171

sikhote opened this issue Jan 2, 2023 · 4 comments · Fixed by #3924
Labels

Comments

@sikhote
Copy link
Contributor

sikhote commented Jan 2, 2023

Is your feature request related to a problem? Please describe.

We are looking to create nested items with only 2 options within. Currently, 4 options are required, otherwise the options will not be grouped.

Describe the solution you'd like

I would like to change the requirements from 4 to 2, if possible.

Describe alternatives you've considered

N/A

Additional context

This is supporting some additions to the alerting plugin, which will be integrating into the main dashboard's context menus. We are adding a context menu for some visualizations. See screenshot below of what we wish to accomplish, but with only 2 options inside the Alerting menu.

Screen Shot 2023-01-02 at 2 43 07 PM

Screen Shot 2023-01-02 at 2 45 16 PM

@sikhote sikhote added the enhancement New feature or request label Jan 2, 2023
@seanneumann
Copy link
Contributor

Is this related to #2880 ??

@sikhote
Copy link
Contributor Author

sikhote commented Jan 3, 2023

@seanneumann I think it's related, but I will refer to @lezzago to answer.

@joshuarrrr
Copy link
Member

Interesting. I can see solid reasons for the previous requirement, but also how it would be useful to leverage grouping more explicitly. Reducing the minimum to 2 seems reasonable, but we'll need to make sure existing dev guidance (both docs and example plugins) are updated as part of the change.

@joshuarrrr
Copy link
Member

@sikhote After chatting with other maintainers, this seems like a fine change, and makes sense in the context of the anywhere feature. Feel free to proceed with the draft PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants