Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] [Enhancement] Support more custom plugin functionality in View Events flyout #3481

Open
Tracked by #2880
ohltyler opened this issue Feb 21, 2023 · 0 comments
Labels

Comments

@ohltyler
Copy link
Member

ohltyler commented Feb 21, 2023

The current page is limited in that only generic VisLayer information is passed as input to the View Events flyout. Ideally, we want to allow plugins to inject more custom logic to enhance the information shown. This can include:

  1. showing resource state (anomaly detectors in Running state, alerting monitors in Enabled state, etc.)
  2. showing more resource information (when last updated, event count over periods of time, more config information)
  3. custom aggregations in tooltips (a scale of anomaly grade & confidence, partitioning alerts based on severity)
  4. custom rendering of event charts (different colors based on event details, such as anomaly grade or alert severity)
  5. custom rendering of other chart types (e.g., line charts for forecasting, or other event types in the future, etc.)

More exploration will be needed in how we want to interface this injected plugin logic (registering logic somewhere?), and the balance of control between core Dashboards and plugins.

UPDATE: more info/proposed ideas in a duplicate issue #4180 . Pasting content here:

Currently, the View Events flyout is specific to PointInTimeEventsVisLayers. The way the flyout is laid out requires tight integration with the base visualization, and the sub-charts below showing each of the VisLayer events. Because of this tight integration, the implementation lives in VisAugmenter plugin in OSD, in order to keep things consistent, such that any plugins that emit events on top of a particular visualization is shown correctly and lined up such that the correlation shown within the flyout looks correct. This also gives us the benefit of all plugins that emit these events, will be organized and shown in a consistent manner for all plugins.

For integrations with future plugins and other potential VisLayer types that may be introduced, we may want to have VisAugmenter have less control over the rendering, and instead allow plugins themselves to control how a deep-dive into the VisLayer may look. For example, for looking at details of forecasting results on top of a visualization, we may want to just show an empty panel at the VisAugmenter level, and allow the plugin responsible for producing the forecasted results, show how they may want to provide more details or a more thorough breakdown of those results.

This can be done using UIActions, such that VisAugmenter could use triggers such that plugins could have actions associated with them to perform different actions (e.g., trigger with context including the visualization to allow the plugin to re-render the visualization along with a detailed breakdown of the forecasted data).

@ohltyler ohltyler added visualizations Issues and PRs related to visualizations unified visualization UX feature-anywhere and removed untriaged labels Feb 21, 2023
@ohltyler ohltyler changed the title [Feature Anywhere] Support more custom plugin functionality in View Events flyout [Feature Anywhere] [P1] Support more custom plugin functionality in View Events flyout Feb 21, 2023
@ohltyler ohltyler changed the title [Feature Anywhere] [P1] Support more custom plugin functionality in View Events flyout [Feature Anywhere] [Future] Support more custom plugin functionality in View Events flyout Feb 21, 2023
@ohltyler ohltyler changed the title [Feature Anywhere] [Future] Support more custom plugin functionality in View Events flyout [Feature Anywhere] [Enhancement] Support more custom plugin functionality in View Events flyout Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant