Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] [Enhancement] Implement custom find()/findAll() for saved object loader #3566

Closed
Tracked by #2880
ohltyler opened this issue Mar 8, 2023 · 1 comment
Labels

Comments

@ohltyler
Copy link
Member

ohltyler commented Mar 8, 2023

The new SavedObjectLoaderAugmentVis loader inherits find()/findAll() fns from SavedObjectLoader. These fns by default only allow searching on title and description fields. For this new loader, the use case is expanded to searching for objects that match a particular vis ID, or plugin resource ID.

Current behavior is just collecting all saved objects and doing post-filtering. Ideally, find()/findAll() are modified to support searching over these new fields so the filtering is done by OpenSearch for us. This can be changed in the base SavedObjectLoader, or overridden in SavedObjectLoaderAugmentVis class. Will need further investigation to decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant