Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Add confirmation dialog on closing flyout for Create & Associate flows with unsaved changes #4331

Open
xeniatup opened this issue Jun 20, 2023 · 5 comments
Labels
enhancement New feature or request feature-anywhere

Comments

@xeniatup
Copy link

xeniatup commented Jun 20, 2023

Is your feature request related to a problem? Please describe.
Feature Anywhere uses OuiFlyout for a variety of experiences inluding "Create/Associate" flows.

Unsaved changes can be lost when flyout is closed.

Describe the solution you'd like

For the Feature Anywhere losing user's progress during Create or Associate flows is not ideal.
If the user has unsaved changes within the "Add alerting monitor", "Add anomaly detector", or "Set up alerts" flyouts and interacts with "Cancel" button in the flyout footer , flyout header "X" (close) or any clicks on the application header, present the user with a confirmation modal.

Screenshot 2023-06-22 at 10 49 24 AM

"Navigate away? Any unsaved progress will be lost." CTAs: "Navigate away" (primary), "Cancel" (secondary).

@xeniatup xeniatup added the enhancement New feature or request label Jun 20, 2023
@ananzh ananzh removed the untriaged label Jun 20, 2023
@ananzh
Copy link
Member

ananzh commented Jun 20, 2023

@KrooshalUX could you help us to check this change?

@xeniatup xeniatup changed the title Add confirmation dialog on closing flyout [Feature Anywhere] Add confirmation dialog on closing flyout Jun 20, 2023
@joshuarrrr joshuarrrr added needs more info Requires more information from poster feature-anywhere labels Jun 20, 2023
@KrooshalUX
Copy link

@ananzh I am working with @xeniatup to make updates to this issue about the pattern that needs to be implemented. This work is for Feature Anywhere team, so OSD team does not need to take any action.

@xeniatup xeniatup changed the title [Feature Anywhere] Add confirmation dialog on closing flyout [Feature Anywhere] Add confirmation dialog on closing flyout for Add/Create flows Jun 20, 2023
@xeniatup xeniatup changed the title [Feature Anywhere] Add confirmation dialog on closing flyout for Add/Create flows [Feature Anywhere] Add confirmation dialog on closing flyout for Create & Associate flows with unsaved changes Jun 22, 2023
@KrooshalUX KrooshalUX removed the needs more info Requires more information from poster label Jun 23, 2023
@KrooshalUX
Copy link

@xeniatup can you assign this to the appropriate team member working on the feature?

@lezzago
Copy link
Member

lezzago commented Jun 27, 2023

I believe that we should have a mechanism built into flyouts to better support for this since there can be many uses to where the use can fill out info in a flyout and submit the info.

@KrooshalUX What are your thoughts on this as I think its should be a core functionality and not specific to Feature Anywhere. Then once the mechanism is built, the feature anywhere can be updated to utilize that flyout mechanism.

@KrooshalUX
Copy link

@lezzago We are considering this change for OUI Flyout, but to unblock and deliver the correct experience for the Anywhere project, I would like to keep that scope separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-anywhere
Projects
None yet
Development

No branches or pull requests

5 participants