[BUG] slide drawer navigation item 'Discover' doesn't have active background when selected

[Abilashinamdar]

Describe the bug

When we open the drawer and select Discover it is not highlighted with an active background color like other items.

To Reproduce
Steps to reproduce the behavior:

1. Click the hamburger icon at the top left.
2. Click on the Discover item in the OpenSearch Dashboards collapsible section.
3. The Discover page will be rendered now.
4. Again repeat step 1.
5. See the Discover item doesn't have an active background color.
6. Other items will have active color if we click and go.

Expected behavior
It should be highlighted with an active background color like other items.

Dashboards Version
v 2.10.0

Screenshots

[ananzh]

Nice catch. Thank you!

[willie-hung]

Hi @ananzh, I would like to work on this issue. Thanks!

[willie-hung]

Overview

While investigating this problem, I discovered that two distinct plugins, discover and data-explorer, are triggered when tapping on the discover tab, leading to the isActive render issue.

Problem

• In the code, it appears that discover and data-explorer are two different instances of core.application. What is the correlation between them?
• The bug occurs when the appId is changed while navigating through the sidebar. Please refer to reference 1 for more details. What is the best practice in this scenario? My first thought is to check whether the appId is discover or data-explorer when the button is tapped. Both conditions should render the button with isActive === true.

Screenshot

Reference

1 - The code that leads to two appId

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/336dce65664cd1f541db33325e5787722443d9c6/src/plugins/discover/public/plugin.ts#L276C1-L281C10

2 - The logic that check whether the button is active or not

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/336dce65664cd1f541db33325e5787722443d9c6/src/core/public/chrome/ui/header/nav_link.tsx#L85C1-L85C28

@joshuarrrr @ashwin-pc @ananzh @BSFishy any guidance would be really appreciate!

[wbeckler]

Can you change the logic so it is more resilient and works for either app id?

[willie-hung]

Hi @wbeckler no problem! I am preparing my midterm exam at the moment, but I plan to submit a pull request within the next week or two.