Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UI Glitch when mouseover Discover document #5230

Closed
seanneumann opened this issue Oct 5, 2023 · 9 comments
Closed

[BUG] UI Glitch when mouseover Discover document #5230

seanneumann opened this issue Oct 5, 2023 · 9 comments
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent good first issue Good for newcomers

Comments

@seanneumann
Copy link
Contributor

Describe the bug

image

When you go to the Discover and mouseover a document, the text shifts when the expand button appears.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to Discover
  2. Make sure there are multiple documents listed
  3. Hover mouse over a document
  4. Notice the text shift when the expand button appears.

Expected behavior
The button should exist on a higher z-index and not manipulate the document space. The text should not shift.

Dashboards Version
2.11 early build

@seanneumann seanneumann added bug Something isn't working untriaged discover for discover reinvent data explorer Issues related to the Data Explorer project labels Oct 5, 2023
@ShatilKhan
Copy link
Contributor

I'd like to take a look at this

@ananzh ananzh added good first issue Good for newcomers v2.12.0 and removed untriaged labels Oct 10, 2023
@kgcreative
Copy link
Member

This may be an implementation bug with the OUI Data Grid component, and how truncation + the hover overlay interacts with each other

@joshuarrrr
Copy link
Member

Yeah, I'm also pretty sure this will first need a fix at the OUI component level.

@ShatilKhan
Copy link
Contributor

Can I get some guidance on what kind of changes should be made on OUI component level @joshuarrrr
Maybe I can open an Issue & work on it in OUI?

@kgcreative
Copy link
Member

So looking at OUI it seems like data grid will float those items by default (there is no text jank in the demo website) -- this leads me to believe there may be some overrides or props that aren't set correctly in the implementation. I would start there

@ShatilKhan
Copy link
Contributor

All right I'll look into OUI & try to understand it

@joshuarrrr
Copy link
Member

@kgcreative Do you know if the demo site have any cells with multiline text (i.e., where the text needs to be wrapped within the cell)? I think that's the failure case we're seeing here.

@kgcreative
Copy link
Member

@kgcreative Do you know if the demo site have any cells with multiline text (i.e., where the text needs to be wrapped within the cell)? I think that's the failure case we're seeing here.

Honestly this seems like an opportunity to expand the examples in the documentation page for data grid, particularly if we plan to use it in more cases. Should we track that in a separate issue?

@ananzh
Copy link
Member

ananzh commented Jun 21, 2024

Can‘t reproduce it any more in data grid table. Legacy table has no such issue. Close it.

@ananzh ananzh closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants