-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover 2.0 - possibility to expand multiple documents at the same time #5555
Comments
@maciejr-gain Thanks for opening up the proposal! @ashwin-pc Since expanding document detail has been changed to a flyout, it makes expanding multiple documents impossible. Should we add feature to allow this? @dagneyb @andrross |
@kgcreative @shanilpa any thoughts on how to solve this with our new layout? |
I want to think about this more. Seems like expanding rows to view document details is a potentially desirable option, but I do think that the larger fly out does help with seeing more at once. We need to explore a few options. First thing that comes to mind is making it so document details could be pinned and floated, that way you could have multiple floating windows that you could arrange and compare. I don't think we have a component for this today, but I could see it being useful for multiple use cases. Other options would be to allow for expanding or inspecting. Expanding would just expand the full json similar to legacy discover, but inspect would be the fully featured flyout with tabs and additional detail. I'm open to other thoughts as well |
First of all, thank you for being interested in helping with this! @kgcreative from my point of view the second proposal seems better tbh. |
@shanilpa can you do a quick exploration of option 2, and propose a different alternative if it comes to mind? Once we have that, then @abbyhu2000 & @ashwin-pc can scope and break it down |
Hey @maciejr-gain - thanks for filing this issue.
These are pretty nitty gritty questions, feel free to answer any you have details on. |
Hi @shanilpa,
I hope this helps, please ping me if you need anything else from me. |
Hey @maciejr-gain thanks for those answers - they definitely helped inform some of the options below. Curious on your thoughts, feedback, and if they address your pain points. Option 1 - Toggle experienceAllowing users to toggle between a flyout, and inline event detail views Expanding.event.options.mp4Benefit to option 1
Disadvantages to option 1
Option 2 - Sliding panels experienceSliding panels that allow users to open multiple flyouts with the option to pin those panels. Benefit to option 2
Disadvantages to option 2
RecommendationPersonally, I think we should go with option 1 short term but aim for something like option 2 long term - with this approach we can have parts of both experiences (user control, and a better pattern for referencing). |
@shanilpa thank you for providing the options! The second options might work well for 2, maybe 3 expanded documents. If someone would like to expand 5 - I'm guessing it will not be readable anymore. If I can vote, my vote is for option 1, no doubt. |
@maciejr-gain thanks for the feedback! @ashwin-pc @abbyhu2000 what would the engineering scope look like to get this change in for the next release? |
I'm aligned with Option 1 FWIW |
Yeah, let's go with option 1 |
cc: @ananzh |
+1 for option 1 (if my vote counts at all as an end user) |
Your voice/vote as a user is even more important tbh |
Hello, Option 1 looks great. Is there any chance to include it in 7.12.0? We have dozens users complaining about that. |
May I work on this? Thank you! |
@MadaniKK Thank you for the help! |
option 1 🎅 |
OpenSearch Dashboards is in version 2; they have no. version 7. |
Yes, I mean 2.12.0, anyway, apparently it will be in 2.13 |
@wbeckler can we prioritize this for 2.12? |
@MadaniKK How is the progress on this issue? Since we wish to target this for 2.12.0, do you have a timeline? |
Hi, I have not started on this issue because I was going to have a meeting with Anan to discuss this issue when she is back from her leave on 17th Jan. What should I do now? |
Yes sure! And it is ok I l still have some other issues to work on first. Thank you! |
Option 1 please ❤️ |
Option 1 🙏 |
Option 1 please 🙏 |
1 similar comment
Option 1 please 🙏 |
We are going with option 1. Thanks for all the feedback :) |
@ashwin-pc @abbyhu2000 could we also work to contribute the changes to data grid back into OUI? This doesn't have to block the release of this enhancement but would be nice to have as an option for use elsewhere in the application. |
We restore legacy table in 2.12, which partially resolve the issue. Now only datagrid table missing this functionality. Update tag: remove bug and 2.12. |
please revert to having inline event detail this is really a downgrade for people using it for debugging and logging. Option 1 |
Is your feature request related to a problem? Please describe.
With all previous versions it was possible to expand as many Discover documents as users needed. It was heavily used by our users to compare few documents while debugging issues.
The new Discover unfortunately removed this possibility. If one document is expanded, in order to expand another one the prior one has to be closed.
This makes investigating by comparing three of four documents very difficult and time consuming.
Would it be possible to somehow bring back the old functionality where user is able to expand few documents at the same time?
Describe the solution you'd like
Possibility to expand multiple documents on the same page
The text was updated successfully, but these errors were encountered: