-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Multiple datasource's datasource id should be required if there is no opensearch hosts config #5699
Comments
@Flyingliuhub Will take a look. Thanks |
Noticed that there is a new type of client "asCurrentUserWithLongNumeralsSupport" get introduced in from this PR: OpenSearch-Dashboards/src/plugins/data/server/search/opensearch_search/decide_client.ts Line 18 in b5d39b6
Based on that change, if we turn on both MD and LongNumeralsSupport, LongNumeralsSupport will not be picked. Will schedule a quick sync up meeting with the author "Miki Barahmand" to make sure that is the expected behavior. Also will update the conclusion here. Thanks |
Have a discussion with "Miki Barahmand" today and make sure LongNumeralsSupport is not necessary for MD. Which means "if we turn on both MD and LongNumeralsSupport, LongNumeralsSupport will not be picked is the expected behavior. We can potentially enable "LongNumeralsSupport" in our MD client, will have a discussion with team to see the priority and will create a separate ticket to track the process if needed. I will move forward based on the expected behavior which will not support "LongNumeralsSupport" in MD client for now. Thanks |
This is duplicate for #5880 |
Describe the bug
Multiple datasource's datasource id should be required if there is no opensearch hosts config, we should check if datasourceid is empty or datasouce context is empty and there is no opernsearch hosts specified, then the request is invalid.
To Reproduce
Steps to reproduce the behavior:
Send empty datasourceid with empty opensearch.hosts in the yaml config returns 500.
Expected behavior
We should check if the datasource Id is empty and return 400 instead of 500.
OpenSearch Version
2.11
Dashboards Version
2.11
Plugins
N/A
Screenshots
N/A
Host/Environment (please complete the following information):
Additional context
N/A
The text was updated successfully, but these errors were encountered: