Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show Line Numbers and Expand/Collapse blocks in JSON view of Expanded Document within Discover. #824

Open
cruzerkk opened this issue Sep 27, 2021 · 3 comments
Labels
discover for discover reinvent enhancement New feature or request ux / ui Improvements or additions to user experience, flows, components, UI elements

Comments

@cruzerkk
Copy link

cruzerkk commented Sep 27, 2021

Recently moved from Kibana to OpenSearch Dashboards. We used to see the option with line numbers and expand collapse blocks of code for JSON docs within Kibana (Discover). However, this option is missing in OpenSearch Dashboards. Is there a request already in place to add this?

@cruzerkk cruzerkk added the enhancement New feature or request label Sep 27, 2021
@kavilla
Copy link
Member

kavilla commented Oct 15, 2021

Hello @cruzerkk, thanks for opening this up. Apologies for the delay.

There hasn't been a request to add it yet.

This feature for code block comes from EUI. Currently, OpenSearch Dashboards is running EUI 29.3.2, the line numbers for code block actually come in for EUI 38.0.0. EUI 38.0.0 would have the license issue as well I believe (as described here).

Therefore the implementation of this would be blocked until we execute the plan for #695.

If it gets folded in this repo then we can keep this issue open here. Wish I could offer a better solution than this blocked for now but thank you again for bringing this up!

@kavilla kavilla removed the untriaged label Oct 15, 2021
@kavilla kavilla changed the title Show Line Numbers and Expand/Collapse blocks in JSON view of Expanded Document within Discover. [Feature] Show Line Numbers and Expand/Collapse blocks in JSON view of Expanded Document within Discover. Oct 15, 2021
@kavilla kavilla added the ux / ui Improvements or additions to user experience, flows, components, UI elements label Oct 15, 2021
@spapadop
Copy link

Hello folks,
having the blocking issue #695 closed, are there any updates here?

@joshuarrrr
Copy link
Member

Hi @spapadop - in #695 we decided to fork the UI library, and that work is underway. However, this feature request will still remain blocked until the forking is complete.

While this functionality belong in the UI library, we'd be open to contributions to add it in a self-contained way to the dashboards code directly in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discover for discover reinvent enhancement New feature or request ux / ui Improvements or additions to user experience, flows, components, UI elements
Projects
None yet
Development

No branches or pull requests

5 participants