fix test

Signed-off-by: guojialiang <guojialiang.2012@bytedance.com>

Author: guojialiang92

libs/ssl-config/src/test/java/org/opensearch/common/ssl/PemTrustConfigTests.java

@@ -74,7 +74,7 @@ public void testBadFileFormatFails() throws Exception {
         Files.write(ca, generateRandomByteArrayOfLength(128), StandardOpenOption.APPEND);
         final PemTrustConfig trustConfig = new PemTrustConfig(Collections.singletonList(ca));
         assertThat(trustConfig.getDependentFiles(), Matchers.containsInAnyOrder(ca));
-        assertFailedToParse(trustConfig, ca);
+        assertFailedToParseOrInvalidFileFormat(trustConfig, ca);
     }
 
     public void testEmptyFileFails() throws Exception {
@@ -121,34 +121,38 @@ public void testTrustConfigReloadsFileContents() throws Exception {
         assertFileNotFound(trustConfig, ca1);
 
         Files.write(ca1, generateRandomByteArrayOfLength(128), StandardOpenOption.CREATE);
+        assertFailedToParseOrInvalidFileFormat(trustConfig, ca1);
+    }
+
+    private void assertCertificateChain(PemTrustConfig trustConfig, String... caNames) {
+        final X509ExtendedTrustManager trustManager = trustConfig.createTrustManager();
+        final X509Certificate[] issuers = trustManager.getAcceptedIssuers();
+        final Set<String> issuerNames = Stream.of(issuers)
+            .map(X509Certificate::getSubjectDN)
+            .map(Principal::getName)
+            .collect(Collectors.toSet());
+
+        assertThat(issuerNames, Matchers.containsInAnyOrder(caNames));
+    }
+
+    private void assertFailedToParseOrInvalidFileFormat(PemTrustConfig trustConfig, Path file) {
         boolean isFailedToParse = false;
         boolean isInvalidFileFormat = false;
         try {
-            assertFailedToParse(trustConfig, ca1);
+            assertFailedToParse(trustConfig, file);
             isFailedToParse = true;
         } catch (Throwable t) {
             // do nothing
         }
         try {
-            assertInvalidFileFormat(trustConfig, ca1);
+            assertInvalidFileFormat(trustConfig, file);
             isInvalidFileFormat = true;
         } catch (Throwable t) {
             // do nothing
         }
         assert isFailedToParse || isInvalidFileFormat;
     }
 
-    private void assertCertificateChain(PemTrustConfig trustConfig, String... caNames) {
-        final X509ExtendedTrustManager trustManager = trustConfig.createTrustManager();
-        final X509Certificate[] issuers = trustManager.getAcceptedIssuers();
-        final Set<String> issuerNames = Stream.of(issuers)
-            .map(X509Certificate::getSubjectDN)
-            .map(Principal::getName)
-            .collect(Collectors.toSet());
-
-        assertThat(issuerNames, Matchers.containsInAnyOrder(caNames));
-    }
-
     private void assertFailedToParse(PemTrustConfig trustConfig, Path file) {
         final SslConfigException exception = expectThrows(SslConfigException.class, trustConfig::createTrustManager);
         logger.info("failure", exception);