Disabled the remote segment Upload decoupled flag

Signed-off-by: Kamal Nayan <askkamal@amazon.com>

Author: Kamal Nayan

server/src/main/java/org/opensearch/indices/RemoteStoreSettings.java

@@ -101,7 +101,7 @@ public class RemoteStoreSettings {
     @ExperimentalApi
     public static final Setting<Boolean> CLUSTER_REMOTE_STORE_REFRESH_SEGMENT_UPLOAD_DECOUPLE = Setting.boolSetting(
         "cluster.remote_store.index.refresh.segment_upload_decouple",
-        true,
+        false,
         Property.NodeScope,
         Property.Dynamic
     );

server/src/test/java/org/opensearch/index/shard/RemoteIndexShardTests.java

@@ -231,11 +231,20 @@ public void testReplicaCommitsInfosBytesOnRecovery() throws Exception {
             RemoteSegmentStoreDirectory remoteSegmentStoreDirectory =
                 (RemoteSegmentStoreDirectory) ((FilterDirectory) ((FilterDirectory) primary.remoteStore().directory()).getDelegate())
                     .getDelegate();
-            assertEquals(
-                "Latest remote commit contains expected segment files",
-                Set.of("_0.cfe", "_0.si", "_0.cfs"),
-                remoteSegmentStoreDirectory.readLatestMetadataFile().getMetadata().keySet()
-            );
+
+            if (primary.isRefreshSegmentUploadDecouplingEnabled()) {
+                assertEquals(
+                    "Latest remote commit contains expected segment files",
+                    Set.of("_0.cfe", "_0.si", "_0.cfs"),
+                    remoteSegmentStoreDirectory.readLatestMetadataFile().getMetadata().keySet()
+                );
+            } else {
+                assertEquals(
+                    "Latest remote commit contains expected segment files",
+                    Set.of("_0.cfe", "_0.si", "_0.cfs", "segments_3"),
+                    remoteSegmentStoreDirectory.readLatestMetadataFile().getMetadata().keySet()
+                );
+            }
 
             try (final GatedCloseable<SegmentInfos> segmentInfosSnapshot = primaryEngine.getSegmentInfosSnapshot()) {
                 MatcherAssert.assertThat(

server/src/test/java/org/opensearch/index/shard/ReplicaRecoveryWithRemoteTranslogOnPrimaryTests.java

@@ -126,7 +126,12 @@ public void testNoTranslogHistoryTransferred() throws Exception {
             primary.awaitRemoteStoreSync();
             List<DocIdSeqNoAndSource> docIdAndSeqNosAfterFlush = getDocIdAndSeqNos(primary);
             int moreDocs = shards.indexDocs(randomIntBetween(20, 100));
-            assertEquals(moreDocs, getTranslog(primary).totalOperations());
+
+            if (primary.isRefreshSegmentUploadDecouplingEnabled()) {
+                assertEquals(moreDocs, getTranslog(primary).totalOperations());
+            } else {
+                assertEquals(moreDocs + numDocs, getTranslog(primary).totalOperations());
+            }
 
             // Step 2 - Start replica, recovery happens, check docs recovered till last flush
             final IndexShard replica = shards.addReplica(remoteDir);