Merge branch 'main' into issue-18750

Signed-off-by: Michael Froh <msfroh@apache.org>

Author: msfroh

.github/workflows/detect-breaking-change.yml

@@ -15,7 +15,7 @@ jobs:
       with:
         cache-disabled: true
         arguments: japicmp
-        gradle-version: 8.14
+        gradle-version: 8.14.3
         build-root-directory: server
     - if: failure()
       run: cat server/build/reports/java-compatibility/report.txt

CHANGELOG.md

@@ -43,9 +43,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Make GRPC transport extensible to allow plugins to register and expose their own GRPC services ([#18516](https://github.com/opensearch-project/OpenSearch/pull/18516))
 - Added approximation support for range queries with now in date field ([#18511](https://github.com/opensearch-project/OpenSearch/pull/18511))
 - Upgrade to protobufs 0.6.0 and clean up deprecated TermQueryProtoUtils code ([#18880](https://github.com/opensearch-project/OpenSearch/pull/18880))
+- Expand fetch phase profiling to multi-shard queries ([#18887](https://github.com/opensearch-project/OpenSearch/pull/18887))
 - Prevent shard initialization failure due to streaming consumer errors ([#18877](https://github.com/opensearch-project/OpenSearch/pull/18877))
 - APIs for stream transport and new stream-based search api action ([#18722](https://github.com/opensearch-project/OpenSearch/pull/18722))
 - Add support for custom remote store segment path prefix to support clusterless configurations ([#18750](https://github.com/opensearch-project/OpenSearch/issues/18750))
+- Added the core process for warming merged segments in remote-store enabled domains ([#18683](https://github.com/opensearch-project/OpenSearch/pull/18683))
+- Optimize Composite Aggregations by removing unnecessary object allocations ([#18531](https://github.com/opensearch-project/OpenSearch/pull/18531))
+- [Star-Tree] Add search support for ip field type ([#18671](https://github.com/opensearch-project/OpenSearch/pull/18671))
 
 ### Changed
 - Update Subject interface to use CheckedRunnable ([#18570](https://github.com/opensearch-project/OpenSearch/issues/18570))
@@ -55,6 +59,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Making multi rate limiters in repository dynamic [#18069](https://github.com/opensearch-project/OpenSearch/pull/18069)
 - Optimize grouping for segment concurrent search by ensuring that documents within each group are as equal as possible ([#18451](https://github.com/opensearch-project/OpenSearch/pull/18451))
 - Move transport-grpc from a core plugin to a module ([#18897](https://github.com/opensearch-project/OpenSearch/pull/18897))
+- Remove `experimental` designation from transport-grpc settings ([#18915](https://github.com/opensearch-project/OpenSearch/pull/18915))
+- Rename package org.opensearch.plugin,transport.grpc to org.opensearch.transport.grpc ([#18923](https://github.com/opensearch-project/OpenSearch/pull/18923))
 
 ### Dependencies
 - Bump `stefanzweifel/git-auto-commit-action` from 5 to 6 ([#18524](https://github.com/opensearch-project/OpenSearch/pull/18524))
@@ -103,6 +109,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Fix leafSorter optimization for ReadOnlyEngine and NRTReplicationEngine ([#18639](https://github.com/opensearch-project/OpenSearch/pull/18639))
 - Close IndexFieldDataService asynchronously ([#18888](https://github.com/opensearch-project/OpenSearch/pull/18888))
 - Fix query string regex queries incorrectly swallowing TooComplexToDeterminizeException ([#18883](https://github.com/opensearch-project/OpenSearch/pull/18883))
+- Fix socks5 user password settings for Azure repo ([#18904](https://github.com/opensearch-project/OpenSearch/pull/18904))
+- Reset isPipelineResolved to false to resolve the system ingest pipeline again. ([#18911](https://github.com/opensearch-project/OpenSearch/pull/18911))
 
 ### Security
 

gradle/wrapper/gradle-wrapper.properties

@@ -1,17 +1,8 @@
-#
-# SPDX-License-Identifier: Apache-2.0
-#
-# The OpenSearch Contributors require contributions made to
-# this file be licensed under the Apache-2.0 license or a
-# compatible open source license.
-#
-# Modifications Copyright OpenSearch Contributors. See
-# GitHub history for details.
-#
-
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14-all.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-all.zip
+networkTimeout=10000
+validateDistributionUrl=true
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
-distributionSha256Sum=efe9a3d147d948d7528a9887fa35abcf24ca1a43ad06439996490f77569b02d1
+distributionSha256Sum=ed1a8d686605fd7c23bdf62c7fc7add1c5b23b2bbc3721e661934ef4a4911d7c

libs/common/src/main/java/org/opensearch/common/recycler/Recycler.java

@@ -32,6 +32,7 @@
 
 package org.opensearch.common.recycler;
 
+import org.opensearch.common.annotation.ExperimentalApi;
 import org.opensearch.common.lease.Releasable;
 
 /**
@@ -40,6 +41,7 @@
  *
  * @opensearch.internal
  */
+@ExperimentalApi
 public interface Recycler<T> {
 
     /**
@@ -73,6 +75,7 @@ interface C<T> {
      *
      * @opensearch.internal
      */
+    @ExperimentalApi
     interface V<T> extends Releasable {
 
         /** Reference to the value. */

modules/transport-grpc/README.md

@@ -9,15 +9,15 @@ The `transport-grpc` module initializes a new client/server transport implementi
 Enable this transport with:
 
 ```
-setting 'aux.transport.types',                              '[experimental-transport-grpc]'
-setting 'aux.transport.experimental-transport-grpc.port',   '9400-9500' //optional
+setting 'aux.transport.types',                              '[transport-grpc]'
+setting 'aux.transport.transport-grpc.port',   '9400-9500' //optional
 ```
 
 For the secure transport:
 
 ```
-setting 'aux.transport.types',                                      '[experimental-secure-transport-grpc]'
-setting 'aux.transport.experimental-secure-transport-grpc.port',    '9400-9500' //optional
+setting 'aux.transport.types',                                      '[secure-transport-grpc]'
+setting 'aux.transport.secure-transport-grpc.port',    '9400-9500' //optional
 ```
 
 
@@ -76,5 +76,5 @@ setting 'grpc.netty.keepalive_timeout',                 '1s'
 To run OpenSearch with the gRPC transport enabled:
 
 ```bash
-./gradlew run -Dtests.opensearch.aux.transport.types="[experimental-transport-grpc]"
+./gradlew run -Dtests.opensearch.aux.transport.types="[transport-grpc]"
 ```

modules/transport-grpc/build.gradle

@@ -11,12 +11,12 @@ apply plugin: 'opensearch.internal-cluster-test'
 
 opensearchplugin {
   description = 'gRPC based transport implementation'
-  classname = 'org.opensearch.plugin.transport.grpc.GrpcPlugin'
+  classname = 'org.opensearch.transport.grpc.GrpcPlugin'
 }
 
 testClusters {
   integTest {
-    setting 'aux.transport.types', '[experimental-transport-grpc]'
+    setting 'aux.transport.types', '[transport-grpc]'
   }
 }
 

modules/transport-grpc/src/internalClusterTest/java/org/opensearch/plugin/transport/grpc/DocumentServiceIT.java renamed to modules/transport-grpc/src/internalClusterTest/java/org/opensearch/transport/grpc/DocumentServiceIT.java

@@ -6,14 +6,14 @@
  * compatible open source license.
  */
 
-package org.opensearch.plugin.transport.grpc;
+package org.opensearch.transport.grpc;
 
-import org.opensearch.plugin.transport.grpc.ssl.NettyGrpcClient;
 import org.opensearch.protobufs.BulkRequest;
 import org.opensearch.protobufs.BulkRequestBody;
 import org.opensearch.protobufs.BulkResponse;
 import org.opensearch.protobufs.IndexOperation;
 import org.opensearch.protobufs.services.DocumentServiceGrpc;
+import org.opensearch.transport.grpc.ssl.NettyGrpcClient;
 
 import io.grpc.ManagedChannel;
 

modules/transport-grpc/src/internalClusterTest/java/org/opensearch/plugin/transport/grpc/GrpcTransportBaseIT.java renamed to modules/transport-grpc/src/internalClusterTest/java/org/opensearch/transport/grpc/GrpcTransportBaseIT.java

@@ -6,16 +6,16 @@
  * compatible open source license.
  */
 
-package org.opensearch.plugin.transport.grpc;
+package org.opensearch.transport.grpc;
 
 import org.opensearch.action.index.IndexResponse;
 import org.opensearch.common.network.NetworkAddress;
 import org.opensearch.common.settings.Settings;
 import org.opensearch.common.xcontent.XContentType;
 import org.opensearch.core.common.transport.TransportAddress;
-import org.opensearch.plugin.transport.grpc.ssl.NettyGrpcClient;
 import org.opensearch.plugins.Plugin;
 import org.opensearch.test.OpenSearchIntegTestCase;
+import org.opensearch.transport.grpc.ssl.NettyGrpcClient;
 
 import java.net.InetSocketAddress;
 import java.util.ArrayList;
@@ -26,8 +26,8 @@
 
 import io.grpc.health.v1.HealthCheckResponse;
 
-import static org.opensearch.plugin.transport.grpc.Netty4GrpcServerTransport.GRPC_TRANSPORT_SETTING_KEY;
 import static org.opensearch.transport.AuxTransport.AUX_TRANSPORT_TYPES_KEY;
+import static org.opensearch.transport.grpc.Netty4GrpcServerTransport.GRPC_TRANSPORT_SETTING_KEY;
 
 /**
  * Base test class for gRPC transport integration tests.

modules/transport-grpc/src/internalClusterTest/java/org/opensearch/plugin/transport/grpc/Netty4GrpcServerTransportIT.java renamed to modules/transport-grpc/src/internalClusterTest/java/org/opensearch/transport/grpc/Netty4GrpcServerTransportIT.java

@@ -6,11 +6,11 @@
  * compatible open source license.
  */
 
-package org.opensearch.plugin.transport.grpc;
+package org.opensearch.transport.grpc;
 
 import org.opensearch.action.admin.cluster.health.ClusterHealthResponse;
 import org.opensearch.cluster.health.ClusterHealthStatus;
-import org.opensearch.plugin.transport.grpc.ssl.NettyGrpcClient;
+import org.opensearch.transport.grpc.ssl.NettyGrpcClient;
 
 import io.grpc.health.v1.HealthCheckResponse;
 

modules/transport-grpc/src/internalClusterTest/java/org/opensearch/plugin/transport/grpc/SearchServiceIT.java renamed to modules/transport-grpc/src/internalClusterTest/java/org/opensearch/transport/grpc/SearchServiceIT.java

@@ -6,13 +6,13 @@
  * compatible open source license.
  */
 
-package org.opensearch.plugin.transport.grpc;
+package org.opensearch.transport.grpc;
 
-import org.opensearch.plugin.transport.grpc.ssl.NettyGrpcClient;
 import org.opensearch.protobufs.SearchRequest;
 import org.opensearch.protobufs.SearchRequestBody;
 import org.opensearch.protobufs.SearchResponse;
 import org.opensearch.protobufs.services.SearchServiceGrpc;
+import org.opensearch.transport.grpc.ssl.NettyGrpcClient;
 
 import io.grpc.ManagedChannel;