Skip to content

Commit 6aaa438

Browse files
committed
Refactored the code
Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
1 parent 9102895 commit 6aaa438

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

server/src/test/java/org/opensearch/cluster/metadata/IndexMetadataTests.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -618,15 +618,13 @@ public void testRemoteStoreSegmentPathPrefixValidation() {
618618

619619
IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.get(emptySettings);
620620

621-
// Test whitespace-only value (should be allowed)
622621
final Settings whitespaceSettings = Settings.builder()
623622
.put(IndexMetadata.INDEX_REMOTE_STORE_ENABLED_SETTING.getKey(), true)
624623
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), " ")
625624
.build();
626625

627626
IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.get(whitespaceSettings);
628627

629-
// Test valid value when remote store is enabled
630628
final Settings validSettings = Settings.builder()
631629
.put(IndexMetadata.INDEX_REMOTE_STORE_ENABLED_SETTING.getKey(), true)
632630
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), "writer-node-1")
@@ -635,7 +633,6 @@ public void testRemoteStoreSegmentPathPrefixValidation() {
635633
String value = IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.get(validSettings);
636634
assertEquals("writer-node-1", value);
637635

638-
// Test that setting throws exception when remote store is disabled
639636
final Settings disabledSettings = Settings.builder()
640637
.put(IndexMetadata.INDEX_REMOTE_STORE_ENABLED_SETTING.getKey(), false)
641638
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), "writer-node-1")
@@ -646,7 +643,6 @@ public void testRemoteStoreSegmentPathPrefixValidation() {
646643
});
647644
assertTrue(e.getMessage().contains("can only be set when"));
648645

649-
// Test that setting throws exception when remote store is not set
650646
final Settings noRemoteStoreSettings = Settings.builder()
651647
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), "writer-node-1")
652648
.build();
@@ -657,7 +653,6 @@ public void testRemoteStoreSegmentPathPrefixValidation() {
657653
);
658654
assertTrue(e.getMessage().contains("can only be set when"));
659655

660-
// Test that setting throws exception when path contains forward slash
661656
final Settings invalidPathSettings = Settings.builder()
662657
.put(IndexMetadata.INDEX_REMOTE_STORE_ENABLED_SETTING.getKey(), true)
663658
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), "writer/node")
@@ -669,7 +664,6 @@ public void testRemoteStoreSegmentPathPrefixValidation() {
669664
);
670665
assertTrue(e.getMessage().contains("cannot contain path separators"));
671666

672-
// Test that setting throws exception when path contains backslash
673667
final Settings backslashSettings = Settings.builder()
674668
.put(IndexMetadata.INDEX_REMOTE_STORE_ENABLED_SETTING.getKey(), true)
675669
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), "writer\\node")
@@ -681,7 +675,6 @@ public void testRemoteStoreSegmentPathPrefixValidation() {
681675
);
682676
assertTrue(e.getMessage().contains("cannot contain path separators"));
683677

684-
// Test that setting throws exception when path contains colon
685678
final Settings colonSettings = Settings.builder()
686679
.put(IndexMetadata.INDEX_REMOTE_STORE_ENABLED_SETTING.getKey(), true)
687680
.put(IndexMetadata.INDEX_REMOTE_STORE_SEGMENT_PATH_PREFIX.getKey(), "writer:node")

0 commit comments

Comments
 (0)