Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the optimization if the individual segment is match all query even though the whole shard is not #11654

Closed
bowenlan-amzn opened this issue Dec 19, 2023 · 1 comment
Assignees
Labels
Search:Aggregations v2.12.0 Issues and PRs related to version 2.12.0

Comments

@bowenlan-amzn
Copy link
Member

Coming from #11083 (comment)

When starting to process each segment, we get the LeafReaderContext which can provide the numDocs of this segment. On the other hand, the weight taking in LeafReaderContext can produce the estimate count of this segment. If these 2 are same, we can treat the weight equivelant as a match-all and it may satisfy the pre-conditions of the fast filters optimization.

@bowenlan-amzn bowenlan-amzn self-assigned this Dec 19, 2023
@bowenlan-amzn bowenlan-amzn converted this from a draft issue Dec 19, 2023
@bowenlan-amzn bowenlan-amzn moved this from Todo to Now (This Quarter) in Performance Roadmap Dec 19, 2023
@getsaurabh02 getsaurabh02 moved this from Now (This Quarter) to In Progress in Performance Roadmap Dec 20, 2023
@getsaurabh02 getsaurabh02 added the v2.12.0 Issues and PRs related to version 2.12.0 label Dec 20, 2023
@kiranprakash154
Copy link
Contributor

Hi, are we on track for this to be released in 2.12 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search:Aggregations v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: Done
Status: No status
Development

No branches or pull requests

3 participants