Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Replication] [Remote Store] Replace overriding mockInternalEngine() in test classes with NRTReplicationEngine #11715

Closed
Rishikesh1159 opened this issue Jan 3, 2024 · 0 comments · Fixed by #11716
Closed

[Segment Replication] [Remote Store] Replace overriding mockInternalEngine() in test classes with NRTReplicationEngine #11715

Rishikesh1159 opened this issue Jan 3, 2024 · 0 comments · Fixed by #11716
Assignees
@Rishikesh1159
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep

Comments

@Rishikesh1159
Copy link
Member

Is your feature request related to a problem? Please describe

Currently many test classes related to segment replication and remote store override mockInternalEngine() to skip usage of Internal Engine for replica shards. Instead of overriding this in every test class we can conditionally return NRTReplicationEngine() from MockEngineFactory

Describe the solution you'd like

Conditionally return NRTReplicationEngine() from MockEngineFactory

Related component

Indexing:Replication

Describe alternatives you've considered

No response

Additional context

No response
@Rishikesh1159 Rishikesh1159 added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 3, 2024
@github-actions github-actions bot added the Indexing:Replication Issues and PRs related to core replication framework eg segrep label Jan 3, 2024
@Rishikesh1159 Rishikesh1159 mentioned this issue Jan 3, 2024
Merged
8 tasks
@Rishikesh1159 Rishikesh1159 self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rishikesh1159 Rishikesh1159

Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep
Projects
None yet
Milestone
No milestone
2 participants
@anasalkouz @Rishikesh1159