Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The org.opensearch.remotestore.CreateRemoteIndexIT.testDefaultRemoteStoreNoUserOverride is flaky #12229

Closed
reta opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Storage:Remote

Comments

@reta
Copy link
Collaborator

reta commented Feb 7, 2024

Describe the bug

The test case org.opensearch.remotestore.CreateRemoteIndexIT.testDefaultRemoteStoreNoUserOverride is flaky:

org.opensearch.remotestore.CreateRemoteIndexIT.testDefaultRemoteStoreNoUserOverride

java.lang.AssertionError: shard [test-idx-1][0] is not locked
	at __randomizedtesting.SeedInfo.seed([AC3DAFC531F23A2A]:0)
	at org.opensearch.env.NodeEnvironment.deleteShardDirectoryUnderLock(NodeEnvironment.java:579)
	at org.opensearch.indices.IndicesService.deleteShardStore(IndicesService.java:1233)
	at org.opensearch.index.IndexService.onShardClose(IndexService.java:678)
	at org.opensearch.index.IndexService$StoreCloseListener.accept(IndexService.java:801)
	at org.opensearch.index.IndexService$StoreCloseListener.accept(IndexService.java:788)
	at org.opensearch.index.store.Store.closeInternal(Store.java:573)
	at org.opensearch.index.store.Store$1.closeInternal(Store.java:194)
	at org.opensearch.common.util.concurrent.AbstractRefCounted.decRef(AbstractRefCounted.java:78)
	at org.opensearch.index.store.Store.decRef(Store.java:546)
	at org.opensearch.index.engine.InternalEngine.refresh(InternalEngine.java:1868)
	at org.opensearch.index.engine.InternalEngine.maybeRefresh(InternalEngine.java:1844)
	at org.opensearch.index.shard.IndexShard.scheduledRefresh(IndexShard.java:4511)
	at org.opensearch.index.IndexService.maybeRefreshEngine(IndexService.java:1026)
	at org.opensearch.index.IndexService$AsyncRefreshTask.runInternal(IndexService.java:1170)
	at org.opensearch.common.util.concurrent.AbstractAsyncTask.run(AbstractAsyncTask.java:159)
	at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:854)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)

Related component

Search

To Reproduce

 ./gradlew ':server:internalClusterTest' --tests "org.opensearch.remotestore.CreateRemoteIndexIT.testDefaultRemoteStoreNoUserOverride" -Dtests.seed=AC3DAFC531F23A2A

Expected behavior

The test must always pass

Additional Details

Plugins
Standard

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • CI

Additional context

@reta reta added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels Feb 7, 2024
@github-actions github-actions bot added the Search Search query, autocomplete ...etc label Feb 7, 2024
@reta reta mentioned this issue Feb 7, 2024
8 tasks
@peternied
Copy link
Member

[Triage - attendees 1 2 3]
@reta Thanks for filing, looking forward to a PR to resolve this.

@ltaragi
Copy link
Contributor

ltaragi commented Jul 10, 2024

Fixed by #14601

@ltaragi ltaragi closed this as completed Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Storage Project Board Jul 10, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Search Project Board Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Storage:Remote
Projects
Status: Done
Status: ✅ Done
Development

No branches or pull requests

5 participants