Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Separation of Merges #12726

Open
linuxpi opened this issue Mar 18, 2024 · 2 comments
Open

[Feature Request] Separation of Merges #12726

linuxpi opened this issue Mar 18, 2024 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request merges Storage Issues and PRs relating to data and metadata storage v3.0.0 Issues and PRs related to version 3.0.0

Comments

@linuxpi
Copy link
Collaborator

linuxpi commented Mar 18, 2024

Is your feature request related to a problem? Please describe

Most of the codebase for Opensearch today exists as a Monolith in :server hosting code related to various background tasks, including Merge. Segment Merges are run from within the Engine and are triggered only on the data node where a particular Shard is assigned.

It would be an anti-pattern to build entire :sever jar and host on Offline Node, which is just responsible for performing Merges.

Current Merge Flow
highlevelmergetrigger drawio(1)

Once IndexWriter triggers a merge, following Merge Component come into play

highlevelmergeflow drawio

Describe the solution you'd like

While maintaining the Status Quo, we need a way to separate out individual components like “Merge” and be able to run separately on Offline Fleet.

Related component

Storage

Describe alternatives you've considered

No response

Additional context

#12361
#12725
#5910

@linuxpi linuxpi added enhancement Enhancement or improvement to existing feature or request untriaged labels Mar 18, 2024
@github-actions github-actions bot added the Storage Issues and PRs relating to data and metadata storage label Mar 18, 2024
@andrross
Copy link
Member

[Triage - attendees 1 2 3 4 5 6]
@linuxpi Thanks, there's not a lot of detail here but I'll go ahead and remove the untriaged label since this looks like something you're tracking in a separate meta issue. In the future, if you'd prefer not to have these issues triaged please remove the label when creating the issue.

@linuxpi
Copy link
Collaborator Author

linuxpi commented Mar 21, 2024

[Triage - attendees 1 2 3 4 5 6] @linuxpi Thanks, there's not a lot of detail here but I'll go ahead and remove the untriaged label since this looks like something you're tracking in a separate meta issue. In the future, if you'd prefer not to have these issues triaged please remove the label when creating the issue.

My bad, i forgot to remove the label. Thanks for removing it! Also, I've added some details here which was definitely missing earlier. This will get more details as we progress further and bring more clarity after exploration

@linuxpi linuxpi added the v3.0.0 Issues and PRs related to version 3.0.0 label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request merges Storage Issues and PRs relating to data and metadata storage v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: Next (Next Quarter)
Development

No branches or pull requests

3 participants