Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Cluster State] Refactor RemoteClusterStateService to small decomposable units for each file write #12881

Closed
shiv0408 opened this issue Mar 23, 2024 · 1 comment · Fixed by #13924
Assignees
Labels
Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request

Comments

@shiv0408
Copy link
Member

          Can we split this class into small and de-composable units for individual file writes and only retain the coordination logic across files formats here. This class is becoming too unwieldy to manage.

Originally posted by @Bukhtawar in #12190 (comment)

@shiv0408
Copy link
Member Author

RemoteClusterStateService.java is getting to big after granular metadata files upload, we need to refactor that class into smaller classes for each kind of files and only keep the Coordination logic in mentioned file for better code cleanliness and maintainability.

The linked PR has already become too big, adding the refactoring will make that PR very difficult to review. So I have opened this issue to create a separate PR for this refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cluster Manager ClusterManager:RemoteState enhancement Enhancement or improvement to existing feature or request
Projects
Status: ✅ Done
3 participants