Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Grouping similar Top N Queries by Latency and Resource Usage #13419

Closed
6 tasks
deshsidd opened this issue Apr 27, 2024 · 2 comments
Closed
6 tasks

[META] Grouping similar Top N Queries by Latency and Resource Usage #13419

deshsidd opened this issue Apr 27, 2024 · 2 comments
Assignees
Labels
Meta Meta issue, not directly linked to a PR Roadmap:Stability/Availability/Resiliency Project-wide roadmap label Search Search query, autocomplete ...etc Telemetry:Performance PRs or issues specific to telemetry performance improvements v2.17.0

Comments

@deshsidd
Copy link
Contributor

Please describe the end goal of this project

In RFC #13357, we proposed to group Top N queries by latency and resource usage using Query shape. For Top N queries by latency, we can encounter scenarios where some (or most) of the Top N queries contain duplicate queries. To overcome such scenarios and to get a more detailed view of the Top N query patterns we are proposing to implement Top N query shapes by resource usage (latency, memory, disk, etc).

Supporting References

RFC: #13357

Issues

Following is the high level break up of tasks of the project. I will keep linking github issues and PRs as and when they are published.

  • Create query shape representation class structure
  • Parse real queries to POJO representation
  • Apply normalizations on the query shape and implement hashcode for the query shape object
  • Enhance or create a new processor to store point in time Top N query shape data by latency
  • Enhance APIs and/or configuration to expose the Top N query shapes feature to the end user and provide the ability to enable/disable the feature
  • Write Unit and integration tests

Related component

Search:Query Insights

@deshsidd deshsidd added Meta Meta issue, not directly linked to a PR untriaged labels Apr 27, 2024
@deshsidd deshsidd moved this from Todo to In Progress in Performance Roadmap Apr 27, 2024
@peternied peternied added the Search Search query, autocomplete ...etc label May 1, 2024
@peternied peternied added Telemetry:Performance PRs or issues specific to telemetry performance improvements and removed untriaged labels May 1, 2024
@peternied
Copy link
Member

[Triage - attendees 1 2 3 4 5 6 7 8]
@deshsidd Thanks for creating this meta issue to track this effort.

@deshsidd deshsidd changed the title [META] Top N Query Shapes by Latency and Resource Usage [META] Grouping similar Top N Queries by Latency and Resource Usage May 29, 2024
@andrross andrross added the Roadmap:Stability/Availability/Resiliency Project-wide roadmap label label May 31, 2024
@github-project-automation github-project-automation bot moved this to Planned work items in OpenSearch Roadmap May 31, 2024
@getsaurabh02 getsaurabh02 added the v2.15.0 Issues and PRs related to version 2.15.0 label Jun 3, 2024
@getsaurabh02 getsaurabh02 added v2.16.0 Issues and PRs related to version 2.16.0 and removed v2.15.0 Issues and PRs related to version 2.15.0 labels Jun 17, 2024
@getsaurabh02 getsaurabh02 added v2.17.0 and removed v2.16.0 Issues and PRs related to version 2.16.0 labels Jul 8, 2024
@getsaurabh02 getsaurabh02 moved this from 🆕 New to Later (6 months plus) in Search Project Board Aug 15, 2024
@deshsidd deshsidd self-assigned this Aug 19, 2024
@github-project-automation github-project-automation bot moved this to 2.17 (First RC 09/03, Release 09/17) in OpenSearch Project Roadmap Aug 30, 2024
@deshsidd
Copy link
Contributor Author

deshsidd commented Sep 5, 2024

resolved in opensearch-project/query-insights#66

@deshsidd deshsidd closed this as completed Sep 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Sep 5, 2024
@github-project-automation github-project-automation bot moved this from Later (6 months plus) to ✅ Done in Search Project Board Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Meta issue, not directly linked to a PR Roadmap:Stability/Availability/Resiliency Project-wide roadmap label Search Search query, autocomplete ...etc Telemetry:Performance PRs or issues specific to telemetry performance improvements v2.17.0
Projects
Status: 2.17 (First RC 09/03, Release 09/17)
Status: New
Status: Done
Status: Done
Development

No branches or pull requests

4 participants