Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Optimise collections in Shard Allocators #14644

Closed
Bukhtawar opened this issue Jul 4, 2024 · 2 comments
Closed

[Feature Request] Optimise collections in Shard Allocators #14644

Bukhtawar opened this issue Jul 4, 2024 · 2 comments
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request ShardManagement:Routing

Comments

@Bukhtawar
Copy link
Collaborator

Bukhtawar commented Jul 4, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe

During reroute of 200k shards, the collections weren't performing optimally

  1. Removing unnecessary List.removeAll from LocalShardsBalancer to filter remote search shard from relocation decision #14613
  2. Optimise PrimaryShardAllocator allocateUnassignedBatch method #14645

Describe the solution you'd like

Change to optimal collections, that can facilitate faster executions

Related component

ShardManagement:Performance

Describe alternatives you've considered

No response

Additional context

No response
@Bukhtawar Bukhtawar added enhancement Enhancement or improvement to existing feature or request untriaged labels Jul 4, 2024
@rwali-aws
Copy link

[Triage - attendees 1 2 3 4 5 6]

@Bukhtawar Thanks for filing this issue. This looks to be duplicate with #14532. Is there any additional/incremental you want to track as part of this issue?

@dblock
Copy link
Member

dblock commented Jul 22, 2024

Closing as dup of #14532, please comment/reopen if this is not the case.

[Catch All Triage w/ 1, 2, 3]

@dblock dblock closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Cluster Manager Project Board Jul 22, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Shard Management Project Board Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request ShardManagement:Routing
Projects
Cluster Manager Project Board
Status: ✅ Done
Shard Management Project Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dblock @Bukhtawar @rwali-aws