Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [Star tree] Nodes with -1 as dimension value gets overriden with star node #15097

Closed
bharath-techie opened this issue Aug 3, 2024 · 2 comments
Assignees
Labels

Comments

@bharath-techie
Copy link
Contributor

Describe the bug

Documents which has dimensions as '-1' , results in getting overriden with star nodes as star nodes are assigned '-1' when constructing star tree.

[-1,1]
[1,1]
[1,1]

Map<Long, InMemoryTreeNode> children = constructNonStarNodes(startDocId, endDocId, childDimensionId);
children.put((long) ALL, constructStarNode(startDocId, endDocId, childDimensionId));

ALL here is '-1'

Related component

Indexing:Performance

To Reproduce

Add documents with -1 as dimensions when creating star tree

Expected behavior

Documents with -1, null and any values in Long range should work with star tree

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@mgodwan
Copy link
Member

mgodwan commented Aug 5, 2024

Lets get rid of

    public static final int ALL = -1;

in TreeNode. That would ensure we have a good rewrite.

Having a starChild separately should help

@bharath-techie
Copy link
Contributor Author

Fixed as part of #14809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants