Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Windows build broken #1637

Closed
mann2108 opened this issue Dec 1, 2021 · 4 comments · Fixed by #1638
Closed

[BUG] Windows build broken #1637

mann2108 opened this issue Dec 1, 2021 · 4 comments · Fixed by #1638
Labels
bug Something isn't working cicd windows

Comments

@mann2108
Copy link

mann2108 commented Dec 1, 2021

Describe the bug
I am trying to run OpenSearch on my local windows machine, and after running gradlew.bat run it's throwing an error.
image

Also, gradlew.bat check command throwing an error. Please find an attached snapshot for your reference.
image
image
image

To Reproduce
Steps to reproduce the behavior:

  1. Clone the opensearch from opensearch-project.
  2. Set up the JAVA_HOME with OpenJDK 11
  3. Run the command gradlew.bat run

Expected behavior
It should run properly without any error.

Plugins
No plugins are enabled right now.

Screenshots
image

Host/Environment (please complete the following information):

  • OS: Windows
  • Version Windows 10
  • OpenJDK - 11
@mann2108 mann2108 added bug Something isn't working untriaged labels Dec 1, 2021
@dblock
Copy link
Member

dblock commented Dec 1, 2021

Looks like there are a couple of problems on Windows.

  1. A CR/LF mismatch between *nix/windows that causes spotless checks to fail. Care to try running the suggestions above (./gradlew.bat :benchmarks:spotlessApply) and PRing the changes?
  2. Failure in :distribution:processOutputs with igest:geoip. This needs debugging, likely a .tar.gz vs. .zip problem.

We don't run CI regularly on Windows, but we should. Maybe we can add a GHA workflow for ./gradlew check on both Windows and Linux here?

There's also a meta item in opensearch-project/opensearch-build#33 for a Windows distribution with a bunch of other workitems.

@dblock dblock added windows and removed untriaged labels Dec 1, 2021
@dblock dblock changed the title [BUG] Cannot able to run using gradlew.bat run command. [BUG] Windows build broken Dec 1, 2021
@dblock dblock added the cicd label Dec 1, 2021
@reta
Copy link
Collaborator

reta commented Dec 1, 2021

@dblock it seems like we could overcome the spotlessApply issues between Windows and / or Linux using .gitattributes, looking into that right now

@dblock
Copy link
Member

dblock commented Dec 3, 2021

@mann2108 This should be now fixed on main.

@mann2108
Copy link
Author

mann2108 commented Dec 6, 2021

@dblock Thanks 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cicd windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants