-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate public or protected method and variable that contains "master" terminology in 'server', 'client/rest', 'client/rest-high-level' and 'test/framework' directory #3544
Comments
Progress update on 07/25/2022: Remaining:
In
1 Reason that the abstract methods in 2 Reason that the methods that return |
Progress update on 07/31/2022:
Remaining:
|
Is your feature request related to a problem? Please describe.
A part of issue #1684.
To support inclusive language, the
master
terminology is going to be replaced bycluster manager
in the code base.The goal for this issue is:
server
,client/rest
,client/rest-high-level
andtest/framework
directories, and the deprecated items will be removed in the next major version (3.0)Describe the solution you'd like
For overall solution to replace "master" in public Java APIs: #1684 (comment)
Key points:
In detail:
master
word withclusterManager
in the method or variable name. This is done by the Rename refactoring feature of IntelliJ IDEA, so that both the definition and reference can be renamed.master
method/vairable definition back.@Deprecated
annotation and@deprecated
Javadoc tag for the method/variable that contains "master" in the name.Describe alternatives you've considered
None.
Additional context
The regex to filter the lines with public or protected method/variable definition contains "master" terminology:
method:
(public|protected)(.)+[Mm]aster(\w)*\(
variable:
(public|protected)(.)+(MASTER|master)(.)*=
Totally 195 methods and 21 variables.
The above number need excluding:
masterOperation()
overrides which will be resolved by Deprecate package 'org.opensearch.action.support.master' #3542List of public methods to be renamed:
in
sever
directory:In
client
directory:In
test/framework
directory:List of public variables to be renamed:
In
client
directory:In
test/framework
directory:(all in
org.opensearch.test.InternalTestCluster
)The text was updated successfully, but these errors were encountered: