Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Reject bulk requests with invalid actions (#5302) #5384

Merged
merged 1 commit into from
Nov 26, 2022
Merged

[Backport 2.x] Reject bulk requests with invalid actions (#5302) #5384

merged 1 commit into from
Nov 26, 2022

Conversation

adnapibar
Copy link
Contributor

Description

Backport #5302

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Rabi Panda adnapibar@gmail.com

The existing bulk api silently ignores bulk item requests that have an invalid action. This change rejects those requests.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar requested review from a team and reta as code owners November 25, 2022 23:53
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #5384 (27ae2c7) into 2.x (9c68587) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                2.x    #5384      +/-   ##
============================================
- Coverage     70.64%   70.62%   -0.02%     
+ Complexity    58334    58323      -11     
============================================
  Files          4700     4700              
  Lines        279089   279092       +3     
  Branches      40750    40751       +1     
============================================
- Hits         197167   197116      -51     
- Misses        65513    65523      +10     
- Partials      16409    16453      +44     
Impacted Files Coverage Δ
.../org/opensearch/action/bulk/BulkRequestParser.java 78.26% <66.66%> (-0.75%) ⬇️
...n/indices/forcemerge/ForceMergeRequestBuilder.java 0.00% <0.00%> (-75.00%) ⬇️
...ch/transport/ReceiveTimeoutTransportException.java 50.00% <0.00%> (-50.00%) ⬇️
...cluster/coordination/PendingClusterStateStats.java 20.00% <0.00%> (-48.00%) ⬇️
...pensearch/action/ingest/DeletePipelineRequest.java 31.25% <0.00%> (-37.50%) ⬇️
...ion/admin/cluster/node/info/PluginsAndModules.java 53.12% <0.00%> (-34.38%) ⬇️
.../indices/forcemerge/TransportForceMergeAction.java 25.00% <0.00%> (-33.34%) ⬇️
...search/aggregations/pipeline/HoltWintersModel.java 21.47% <0.00%> (-30.88%) ⬇️
...rc/main/java/org/opensearch/ingest/IngestInfo.java 51.72% <0.00%> (-27.59%) ⬇️
...opensearch/index/reindex/BulkByScrollResponse.java 48.38% <0.00%> (-27.42%) ⬇️
... and 441 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reta reta merged commit 452ed77 into opensearch-project:2.x Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants