Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle test setup to consider test iterations for suite timeout #5630

Open
dreamer-89 opened this issue Dec 24, 2022 · 2 comments
Open
Labels
bug Something isn't working Build Libraries & Interfaces CCI College Contributor Initiative related issues and PRs enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Priority-Medium :test Adding or fixing a test

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Dec 24, 2022

Coming from #1561 (comment), existing test setup does not consider the test iteration count (-Dtests.iters) and uses 20 mins test suite timeout. This is problematic as it often leads to test suite timeout.

Alternative: Update timeout to a higher value. This is not an ideal solution.

@dreamer-89 dreamer-89 added bug Something isn't working enhancement Enhancement or improvement to existing feature or request untriaged labels Dec 24, 2022
@tlfeng tlfeng added :test Adding or fixing a test Build Libraries & Interfaces labels Dec 27, 2022
@minalsha minalsha added the good first issue Good for newcomers label Mar 24, 2023
@Rishikesh1159 Rishikesh1159 added the CCI College Contributor Initiative related issues and PRs label Apr 5, 2023
@JalODan
Copy link

JalODan commented Apr 8, 2023

Hi, @dreamer-89. I tried to reproduce this issue, but could not. TimeoutSuite is set to 20 minute. Author of the issue says that these 20 minutes are shared by 100 iterations of the test. From this assumption it follows that, if execution time of 100 iterations exceeds 20 minutes a timeout would occur. But when I tried it locally, everything works fine:
image
From the image we can see that they run for longer than 20 minutes. It means, that each instance of the test running gets its own 20 minutes, and does not share it with other instances. And therefore, there is no such problem. Please correct me If am wrong.

@dreamer-89
Copy link
Member Author

dreamer-89 commented Apr 9, 2023

Hi, @dreamer-89. I tried to reproduce this issue, but could not. TimeoutSuite is set to 20 minute. Author of the issue says that these 20 minutes are shared by 100 iterations of the test. From this assumption it follows that, if execution time of 100 iterations exceeds 20 minutes a timeout would occur. But when I tried it locally, everything works fine: image From the image we can see that they run for longer than 20 minutes. It means, that each instance of the test running gets its own 20 minutes, and does not share it with other instances. And therefore, there is no such problem. Please correct me If am wrong.

Thank you @JalODan for looking into this. This is interesting!

Good to know this is not a problem when tests are ran from IDE. Though, I see the issue was initially reported when test was ran with gradle command. Can you try running tests with gradle command below ?

./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards" -Dtests.seed=3ADB1F144D29EAD6 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en -Dtests.timezone=America/Lower_Princes -Druntime.java=17 -Dtests.iters=100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Build Libraries & Interfaces CCI College Contributor Initiative related issues and PRs enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers Priority-Medium :test Adding or fixing a test
Projects
None yet
Development

No branches or pull requests

5 participants