Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace static methods in Translog with instance methods #5679

Open
sachinpkale opened this issue Jan 3, 2023 · 0 comments
Open

Replace static methods in Translog with instance methods #5679

sachinpkale opened this issue Jan 3, 2023 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework

Comments

@sachinpkale
Copy link
Member

Is your feature request related to a problem? Please describe.

  • Static methods in Translog class allows accessing translog files without creating an instance of Translog.
  • Even though this makes things convenience in recovery flow, it breaks the separation of concerns and with these static methods, maintaining Translog implementations becomes non-trivial.
  • This feature request proposes changing all these static methods to instance methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Storage:Durability Issues and PRs related to the durability framework
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant