Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point in time based searches should provide an option to ignore missing indices #7418

Open
SingingTree opened this issue May 4, 2023 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request Search:Remote Search

Comments

@SingingTree
Copy link

Is your feature request related to a problem? Please describe.
If a point in time is created against an index that is then deleted, searches using that point in time will fail. This is problematic if a point in time is created against all indices, and one of those indices is then dropped while the PIT is still in use. An example of this occurring is that lifecycle management may drop an old index in the middle of a search.

A minimal way to reproduce this is:

  1. Stand up an OpenSearch cluster.
  2. Add 2 indices -- index-1 and index-2
  3. Create a PIT against _all
  4. (Optionally) Test that a search with the PIT works
  5. Delete index-2
  6. Test that a search with the PIT fails with a 404 indicating that an index is missing.

Describe the solution you'd like
Allow PITs to specify something like allow_partial_search_results which then returns search results while ignoring missing indices similar to non-PIT searches.

Describe alternatives you've considered
This can be managed on the client by creating a new PIT and searching again, however this is cumbersome.

Additional context
Elasticsearch have tracked a similar issue in elastic/elasticsearch#81256 and have implemented a fix to the problem described in elastic/elasticsearch#81349

@SingingTree SingingTree added enhancement Enhancement or improvement to existing feature or request untriaged labels May 4, 2023
@andrross andrross added the Search Search query, autocomplete ...etc label May 30, 2023
@msfroh
Copy link
Collaborator

msfroh commented May 30, 2023

As an admin task, we should probably create a dedicated label for point-in-time search, to ensure that the right folks get their eyes on this. Those of us who follow the Search label probably don't have enough context to dive in on PIT stuff.

In the meantime, @bharath-techie -- do you know of a project where we can assign this so that it gets some traction? Thanks!

@msfroh msfroh removed the untriaged label May 30, 2023
@bharath-techie
Copy link
Contributor

The one in which we were tracking PIT backend tasks is closed - #1147

We can create a new one if needed.

@anasalkouz anasalkouz added Search:Remote Search and removed Search Search query, autocomplete ...etc labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Remote Search
Projects
None yet
Development

No branches or pull requests

5 participants