Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minimum file cache size restriction #8259

Closed
andrross opened this issue Jun 26, 2023 · 0 comments · Fixed by #8294
Closed

Remove minimum file cache size restriction #8259

andrross opened this issue Jun 26, 2023 · 0 comments · Fixed by #8294
Assignees
Labels
bug Something isn't working distributed framework

Comments

@andrross
Copy link
Member

The current file cache factory has the requirement that each cache segment must be larger than the block size. This restriction was put into place because the initial behavior of the cache would immediately close a newly added entry if the cache was full. This meant that if the segment size was smaller than the block size then nothing would work. In practice this was never really an issue because useful cache sizes are multiple orders of magnitude larger than the block size. However, now that #6592 has been implemented this restriction can be removed. The restriction isn't harmful per se, but it can make testing awkward, so it should be removed. The code in question is here. This task is to remove that condition and update tests accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed framework
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants