Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Tracing Instrumentation] Add instrumentation in InboundHandler #10381

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport aac0f09 from #10143.

* Add instrumentation in InboundHandler

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Add CHANGELOG

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Empty-Commit

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Address review comment

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
(cherry picked from commit aac0f09)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Compatibility status:

Checks if related components are compatible with change 2e94263

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testShallowCloneNameAvailability
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDeleteOperations

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #10381 (2e94263) into 2.x (9c678ab) will increase coverage by 0.11%.
Report is 9 commits behind head on 2.x.
The diff coverage is 88.28%.

@@             Coverage Diff              @@
##                2.x   #10381      +/-   ##
============================================
+ Coverage     70.78%   70.89%   +0.11%     
- Complexity    58370    58426      +56     
============================================
  Files          4818     4820       +2     
  Lines        275947   275988      +41     
  Branches      40554    40554              
============================================
+ Hits         195318   195653     +335     
+ Misses        63971    63674     -297     
- Partials      16658    16661       +3     
Files Coverage Δ
...g/opensearch/transport/netty4/Netty4Transport.java 73.65% <100.00%> (ø)
...ava/org/opensearch/transport/nio/NioTransport.java 92.06% <100.00%> (ø)
...a/org/opensearch/common/network/NetworkModule.java 92.00% <ø> (ø)
...arch/index/remote/RemoteStorePressureSettings.java 80.64% <ø> (-6.46%) ⬇️
...ain/java/org/opensearch/plugins/NetworkPlugin.java 100.00% <ø> (ø)
.../opensearch/transport/BaseTcpTransportChannel.java 100.00% <100.00%> (ø)
...g/opensearch/transport/RequestHandlerRegistry.java 87.87% <100.00%> (ø)
...in/java/org/opensearch/transport/TcpTransport.java 86.22% <ø> (ø)
...in/java/org/opensearch/transport/Netty4Plugin.java 73.68% <0.00%> (ø)
...g/opensearch/transport/nio/NioTransportPlugin.java 25.00% <0.00%> (ø)
... and 6 more

... and 472 files with indirect coverage changes

@Gaganjuneja
Copy link
Contributor

@reta, Could you please merge this one. Thanks!

@reta
Copy link
Collaborator

reta commented Oct 5, 2023

@reta, Could you please merge this one. Thanks!

@Gaganjuneja please prepare the fix for security plugin right away, thank you

@reta reta merged commit 890663f into 2.x Oct 5, 2023
61 checks passed
@github-actions github-actions bot deleted the backport/backport-10143-to-2.x branch October 5, 2023 13:21
@reta reta added the v2.11.0 Issues and PRs related to version 2.11.0 label Oct 5, 2023
@Gaganjuneja
Copy link
Contributor

Gaganjuneja commented Oct 5, 2023

@reta, Could you please merge this one. Thanks!

@Gaganjuneja please prepare the fix for security plugin right away, thank you

Which one you are talking about here? the IllegalStateException one?

@reta
Copy link
Collaborator

reta commented Oct 5, 2023

Which one you are talking about here? the IllegalStateException one?

opensearch-project/security#3469
opensearch-project/security#3468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.11.0 Issues and PRs related to version 2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants