Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update reporting menu item UI to support variable header heights #56

Open
joshuarrrr opened this issue Jun 8, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@joshuarrrr
Copy link
Member

What is the bug?
In the 2.1.0 release of Opensearch Dashboards, we're planning to add a configurable option for either a condensed (single-line) or expanded (2-line) global header. However, this plugin currently hard-codes the header height into the popover positioning, which means the popover will no longer align with the menu link in the default mode:

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Pull the feature branch of opensearch dashboards, or simply change the multiplier here to 1.
  2. Load opensearch dashboards with the dashboard-reports plugin and click on the Reporting menu link.

What is the expected behavior?
Because the plugin is responsible for rendering both the menu link and popover, it should use the correct EUI components, which will take care of positioning the popover relative to the menu link. Instead of building up large HTML strings with template literals, using EUI React components will make the UI controls much more maintainable and standardized.

@joshuarrrr joshuarrrr added bug Something isn't working untriaged labels Jun 8, 2022
@rupal-bq rupal-bq transferred this issue from opensearch-project/reporting Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants