-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add Windows Support #16
Comments
Build failed on Windows. Added the following to the workflow, but it still failed.
@peterzhuamazon, any ideas? |
One more question, this is an experimental feature in 2.4. Given that, must it work on Windows? |
@macohen expectation is that any plugin on-boarded to 2.4.0 release should have working Windows CI on their repo to support that distribution going forward. |
@macohen Are integration/cypress tests running on Windows, and/or are there any coverage differences between Linux and Windows tests? If yes, please reopen this issue until that gap is covered. |
Looks like the integration tests are only running on Ubuntu for now: https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.github/workflows/search-relevance-release-e2e-workflow.yml#L9 |
(All of the other e2e testing workflows in opensearch-dashboards-functional-test seem to use ubuntu-latest as well, though.) |
builds pass CI for windows. we've been entirely focused on integ tests at this point. @bbarani What documentation are you looking for on this? Are there any examples? |
Windows CI is passing. Closing issue. |
Coming from opensearch-project/opensearch-plugins#95, add Windows support.
The text was updated successfully, but these errors were encountered: