Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing plugins to use POJO configuration classes. #5246

Open
2 tasks
Tracked by #2000
dlvenable opened this issue Dec 6, 2024 · 1 comment
Open
2 tasks
Tracked by #2000

Migrate existing plugins to use POJO configuration classes. #5246

dlvenable opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Milestone

Comments

@dlvenable
Copy link
Member

dlvenable commented Dec 6, 2024

All plugins should configure the pluginConfigurationType attribute in @DataPrepperPlugin with a custom POJO configuration class. Some older plugins still use PluginSettings. These should be updated to use a POJO configuration class.

For example, the s3 source does this correctly.

@DataPrepperPlugin(name = "s3", pluginType = Source.class, pluginConfigurationType = S3SourceConfig.class)

The opensearch sink is doing this using PluginSettings which we do not want.

  • Update the OpenSearch sink to use a POJO configuration class.
  • Look for any other plugins that use the PluginSettings.
@Galactus22625 Galactus22625 moved this from Unplanned to In progress in Data Prepper Tracking Board Dec 6, 2024
@Galactus22625 Galactus22625 moved this from In progress to Unplanned in Data Prepper Tracking Board Dec 6, 2024
@dlvenable dlvenable added maintenance Issues to help maintain the project, such as improving builds, testing, etc. and removed untriaged labels Dec 10, 2024
@Galactus22625
Copy link
Member

I can do

@dlvenable dlvenable added this to the v2.11 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issues to help maintain the project, such as improving builds, testing, etc.
Projects
Development

No branches or pull requests

2 participants