Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Concurrent Segment Search is disabled in terminate_after workflow #5142

Closed
1 of 4 tasks
jed326 opened this issue Oct 3, 2023 · 0 comments · Fixed by #5143
Closed
1 of 4 tasks

[DOC] Concurrent Segment Search is disabled in terminate_after workflow #5142

jed326 opened this issue Oct 3, 2023 · 0 comments · Fixed by #5143
Assignees
Labels
3 - Done Issue is done/complete v2.11.0
Milestone

Comments

@jed326
Copy link
Contributor

jed326 commented Oct 3, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Sample proposed wording:
For concurrent segment search we are disabling concurrent segment search when the terminate_after parameter is used. With terminate_after we typically expect the queries to be used with smaller values and thus complete very quickly as this effectively reduces the dataset size on which search is done, so concurrent search may not really help with such cases. Moreover, due to added complexity when used with other search request parameters including track_total_hits and size, the behavior changes with terminate_after after therefore we are falling back to non-concurrent path for these search requests to ensure consistent results between concurrent and non-concurrent requests.

Affected section: https://github.com/opensearch-project/documentation-website/blob/main/_search-plugins/concurrent-segment-search.md#the-terminate_after-search-parameter

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
opensearch-project/OpenSearch#10200

@kolchfa-aws kolchfa-aws added this to the v2.11 milestone Oct 3, 2023
@kolchfa-aws kolchfa-aws self-assigned this Oct 3, 2023
@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete v2.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants