Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Diversified Sampler Agg doc does not include max_docs_per_value parameter #5509

Closed
1 of 4 tasks
jed326 opened this issue Nov 3, 2023 · 2 comments · Fixed by #6134
Closed
1 of 4 tasks

[DOC] Diversified Sampler Agg doc does not include max_docs_per_value parameter #5509

jed326 opened this issue Nov 3, 2023 · 2 comments · Fixed by #6134
Assignees
@jed326
Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started aggregations and analyzers Sev3 Medium priority. Content that's missing, driven by dev, PM or the community.

Comments

@jed326
Copy link
Contributor

jed326 commented Nov 3, 2023

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
The doc https://opensearch.org/docs/latest/aggregations/bucket/diversified-sampler/ is missing the max_docs_per_value parameter. Additionally, it would be good to have a short description of what these parameters do.

For more details see: opensearch-project/OpenSearch#11075
@jed326 jed326 mentioned this issue Nov 3, 2023
Open
@Naarcha-AWS Naarcha-AWS added 1 - Backlog Issue: The issue is unassigned or assigned but not started good first issue Good for newcomers aggregations and analyzers Sev3 Medium priority. Content that's missing, driven by dev, PM or the community. and removed untriaged labels Nov 15, 2023
@hdhalter
Copy link
Contributor

@jed326 - Would you like to take a stab at updating the documentation?

@jed326
Copy link
Contributor Author

jed326 commented Nov 29, 2023

@hdhalter sure, I think I have a few docs PRs I'm planning to open in the next week or two so I can just take them all together

@hdhalter hdhalter removed the good first issue Good for newcomers label Nov 29, 2023
@jed326 jed326 mentioned this issue Jan 12, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jed326 jed326

Labels
1 - Backlog Issue: The issue is unassigned or assigned but not started aggregations and analyzers Sev3 Medium priority. Content that's missing, driven by dev, PM or the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max_docs_per_value to diversified sampler documentation jed326/documentation-website
3 participants
@jed326 @Naarcha-AWS @hdhalter