Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Move BWC tests to their own gradle build #555

Open
dbwiddis opened this issue Mar 8, 2024 · 1 comment
Open

[REFACTOR] Move BWC tests to their own gradle build #555

dbwiddis opened this issue Mar 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Mar 8, 2024

Coming from #551 (comment)

Is your feature request related to a problem?

The build.gradle file is getting big and confusing to navigate.

What solution would you like?

Change our BWC setup (derived from AD and ML Commons setup) to the Security repo pattern.

See https://github.com/opensearch-project/security/blob/main/bwc-test/build.gradle

What alternatives have you considered?

Leave it as is, to reduce a lot of the duplication that will be required.

Refactor to a completely different model as some other plugins are doing.

Do you have any additional context?

It took several hours to get this working. I don't expect this will be a trivial exercise to move it.

Other possibilities mentioned in #551 review:

  • try to run on Windows
  • simplify some code in BWC test (and submit similar changes to AD and ML Commons)
@amitgalitz
Copy link
Member

KNN also has a good example of separating rolling and restart upgrade somewhere else: https://github.com/opensearch-project/k-NN/blob/2.x/qa/rolling-upgrade/build.gradle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants