Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EnginePlugin to use new CodecService Override extension #147

Closed
nknize opened this issue Oct 21, 2021 · 0 comments
Closed

Refactor EnginePlugin to use new CodecService Override extension #147

nknize opened this issue Oct 21, 2021 · 0 comments
Assignees
Labels
bug Something isn't working enhancement v2.0.0

Comments

@nknize
Copy link

nknize commented Oct 21, 2021

OpenSearch inherited a limitation that only allows a single plugin to override the core Engine. This is problematic because at present there are at least two OpenSearch plugins that Override the Engine under different IndexSettings cirucmstances; K-NN and CCR. This means CCR will be unable to replicate KNN indices since the Engine will prevent both plugins from being used in the same index.

OpenSearch/#1401 adds a new extension point to EngineConfig through EnginePlugin to enable plugins to override the CodecService instead of overriding the entire Engine. Note this does not fix a current bug in the implementation of the KNNCodec that silently ignores codec modes like best_compression. That bug should be worked separately and independently of refactoring the Plugin to use the CodecService extension point.

This change should be non-breaking since it simply changes the injection point of the service. Engine behavior remains the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement v2.0.0
Projects
None yet
Development

No branches or pull requests

3 participants