-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MacOS Support #158
Comments
The mac os support is present in K-NN. Resolving this issue |
Hi @navneet1v @jmazanec15 @navneet1v , Could you let me know if k-NN now fully support build and run on both x64 and arm64 macOS? Thanks. |
@peterzhuamazon We have CI working for mac https://github.com/opensearch-project/k-NN/blob/main/.github/workflows/CI.yml#L95-L134. I believe this will run with arm64. Locally, k-NN is able to build on x86. |
Thanks @jmazanec15 seems like it is ready to go 👍 |
Sorry for this naive question, but what will be the next steps to make kNN work for MacOS users? I just tried it with OpenSearch 2.17.1 installed on arm64 MacOS and it still throws me an error: {
"error": {
"root_cause": [
{
"type": "illegal_argument_exception",
"reason": "unknown setting [index.knn] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
}
],
"type": "illegal_argument_exception",
"reason": "unknown setting [index.knn] please check that any required plugins are installed, or check the breaking changes documentation for removed settings",
"suppressed": [
{
"type": "illegal_argument_exception",
"reason": "unknown setting [index.knn.algo_param.ef_construction] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
},
{
"type": "illegal_argument_exception",
"reason": "unknown setting [index.knn.algo_param.ef_search] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
},
{
"type": "illegal_argument_exception",
"reason": "unknown setting [index.knn.algo_param.m] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
},
{
"type": "illegal_argument_exception",
"reason": "unknown setting [index.knn.space_type] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"
}
]
},
"status": 400
} |
Coming from opensearch-project/opensearch-plugins#96, add MacOS (Darwin) support.
The text was updated successfully, but these errors were encountered: