Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]Remove double converting from byte[] to float[], and float[] to byte[] for script scoring with binary vector #1827

Open
heemin32 opened this issue Jul 15, 2024 · 4 comments

Comments

@heemin32
Copy link
Collaborator

In #1826 which support script scoring on knn binary vector, we convert byte[] to float[] and again float[] to byte[] which will add a latency during query using script scoring on knn binary vector. We want to avoid the unnecessary converting.

@heemin32 heemin32 added Refactoring Improve the design, structure, and implementation while preserving its functionality and removed untriaged labels Jul 15, 2024
@navneet1v
Copy link
Collaborator

@heemin32 why we are not resolving this as part of 2.16 when this impacts the latency?

@heemin32
Copy link
Collaborator Author

It is not a trivial change and 2.16 code freeze is just a next Monday. Score script is already slow compared to ANN and the impact on latency due to double converting could be negligible though actual profiling might be needed to confirm.

@navneet1v
Copy link
Collaborator

and the impact on latency due to double converting could be negligible

till we don't have benchmarks we cannot say this. and leaving optimization out of a release doesn't seem correct to me.

@heemin32
Copy link
Collaborator Author

and the impact on latency due to double converting could be negligible

till we don't have benchmarks we cannot say this. and leaving optimization out of a release doesn't seem correct to me.

Optimization can be implemented incrementally. That is how it has been till now.

@heemin32 heemin32 removed the Refactoring Improve the design, structure, and implementation while preserving its functionality label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog (Hot)
Development

No branches or pull requests

2 participants