Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintainence] Enable indices.breaker.total.use_real_memory setting while via build.gradle for integTest Cluster to catch heap CB. #2114

Open
navneet1v opened this issue Sep 18, 2024 · 0 comments
Labels
good first issue Good for newcomers Maintenance Add support for new versions of OpenSearch/Dashboards from upstream

Comments

@navneet1v
Copy link
Collaborator

navneet1v commented Sep 18, 2024

Background

Currently in opensearch plugins use ./gradlew :integTest to run the ITs on local and also on the CIs. The commands create a local cluster and run the tests against it. On this local cluster CBs are disabled. Ref: https://github.com/opensearch-project/OpenSearch/blob/767c07f46d361a991b3b6ea2afc2ac501f63b04e/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java#L1179-L1182

Due to this what happens is if there is some issues in the code that didn't get caught during CIs. This issue recently happened with k-NN plugin where in of the flow plugin was creating some large objects which was not required(Fix PR: #2070). But none of the CIs were able to caught this and it was caught during the Jenkins IT runs as those runs happen remote cluster built using the generated distribution where the setting indices.breaker.total.use_real_memory is marked as true. In test cluster that gets created during CIs has this setting as False. Ref: https://github.com/opensearch-project/OpenSearch/blob/767c07f46d361a991b3b6ea2afc2ac501f63b04e/buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java#L1179-L1182

What Needs to be done

With this gh issue: opensearch-project/OpenSearch#15849, Opensearch now supports overriding indices.breaker.total.use_real_memory in integTest cluster. We should enable this setting to ensure that CIs and local integ test now start to run with heap CB enabled.

@navneet1v navneet1v added the Maintenance Add support for new versions of OpenSearch/Dashboards from upstream label Sep 18, 2024
@navneet1v navneet1v added good first issue Good for newcomers and removed untriaged labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Maintenance Add support for new versions of OpenSearch/Dashboards from upstream
Projects
Status: Backlog
Development

No branches or pull requests

1 participant